Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DFP Viz dependencies to DFP container #873

Merged

Conversation

efajardo-nv
Copy link
Contributor

@efajardo-nv efajardo-nv commented Apr 12, 2023

Description

  • Add nodejs install to conda_env.yml.
  • Remove instructions to manually install nodejs and update LD_LIBRARY_PATH from DFP Viz README.

Closes #830
Fixes #882

Checklist

[x] I am familiar with the Contributing Guidelines.
[x] New or existing tests cover these changes.
[x] The documentation is up to date with these changes.

@efajardo-nv efajardo-nv added non-breaking Non-breaking change improvement Improvement to existing functionality labels Apr 12, 2023
@efajardo-nv efajardo-nv marked this pull request as ready for review April 13, 2023 15:47
@efajardo-nv efajardo-nv requested a review from a team as a code owner April 13, 2023 15:47
@efajardo-nv efajardo-nv marked this pull request as draft April 13, 2023 18:06
@efajardo-nv efajardo-nv marked this pull request as ready for review April 28, 2023 23:28
Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we update the external viz submodule to the latest commit on 23.07?

@efajardo-nv efajardo-nv requested a review from a team as a code owner May 1, 2023 19:23
Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@mdemoret-nv
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 441ad32 into nv-morpheus:branch-23.07 May 5, 2023
@efajardo-nv efajardo-nv deleted the dfp-viz-container-deps branch July 29, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement to existing functionality non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG]: Remove LD_LIBRARY hack in DFP visualization [FEA]: Add missing DFP Viz dependencies to container
2 participants