Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to CuDF 23.02 and MRC 23.07 #848

Merged
merged 25 commits into from
Apr 13, 2023
Merged

Update to CuDF 23.02 and MRC 23.07 #848

merged 25 commits into from
Apr 13, 2023

Conversation

cwharris
Copy link
Contributor

@cwharris cwharris commented Apr 5, 2023 •
edited by mdemoret-nv
Loading

Updates CUDF to 23.02 and MRC to 23.07.

Notable changes include new better phishing results. This is because CUDF has updated the default JSON parser to a newer better nested JSON parser with better UTF-8 support.

Closes #601

@cwharris cwharris added breaking Breaking change feature request New feature or request labels Apr 5, 2023
mdemoret-nv
mdemoret-nv reviewed Apr 6, 2023
View reviewed changes
Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of comments.

ci/conda/recipes/morpheus/meta.yaml Outdated Show resolved Hide resolved
ci/conda/recipes/morpheus/meta.yaml Show resolved Hide resolved
scripts/compile.sh Outdated Show resolved Hide resolved
@cwharris cwharris marked this pull request as ready for review April 10, 2023 16:43
@cwharris cwharris requested review from a team as code owners April 10, 2023 16:43
mdemoret-nv
mdemoret-nv approved these changes Apr 10, 2023
View reviewed changes
morpheus/_lib/cudf_helpers.pyx Outdated Show resolved Hide resolved
@cwharris cwharris mentioned this pull request Apr 12, 2023
Closed
mdemoret-nv
mdemoret-nv requested changes Apr 13, 2023
View reviewed changes
Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thought of a few more things. Also, can you look at whether this is needed anymore? We used to have to perform some cleanup when reading JSON with cudf. With their new JSON deserializer, I wonder if this is needed anymore. Matching code for python is located here

docker/conda/environments/cuda11.8_dev.yml Show resolved Hide resolved
ci/conda/recipes/morpheus/conda_build_config.yaml Outdated Show resolved Hide resolved
docker/conda/environments/cuda11.8_dev.yml Show resolved Hide resolved
mdemoret-nv
mdemoret-nv approved these changes Apr 13, 2023
View reviewed changes
Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good once tests pass

@mdemoret-nv mdemoret-nv mentioned this pull request Apr 13, 2023
Closed
@cwharris
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 45673f4 into nv-morpheus:branch-23.07 Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdemoret-nv mdemoret-nv mdemoret-nv approved these changes

Assignees
No one assigned
Labels
breaking Breaking change feature request New feature or request
Projects
Morpheus Boards
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Upgrade protobuf to version 4.xx.xx
2 participants
@cwharris @mdemoret-nv