Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Parquet file input #770

Merged
merged 25 commits into from
Mar 28, 2023

Conversation

efajardo-nv
Copy link
Contributor

@efajardo-nv efajardo-nv commented Mar 16, 2023

  • Add FileTypes.PARQUET enum to support Parquet file input in deserializers.py
  • Update deserializers.py to handle Parquet file input for FileTypes.PARQUET and FileTypes.Auto
  • Add tests for parquet and jsonlines file input

Closes #767

@efajardo-nv efajardo-nv added non-breaking Non-breaking change feature request New feature or request labels Mar 16, 2023
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@efajardo-nv efajardo-nv marked this pull request as ready for review March 16, 2023 21:18
@efajardo-nv efajardo-nv requested a review from a team as a code owner March 16, 2023 21:18
Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need some tests for ensuring parquet file reading/writing is working correctly. Append onto the test_file_in_out.py

morpheus/_lib/src/objects/file_types.cpp Outdated Show resolved Hide resolved
morpheus/io/deserializers.py Outdated Show resolved Hide resolved
@mdemoret-nv
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 808f996 into nv-morpheus:branch-23.03 Mar 28, 2023
@efajardo-nv efajardo-nv deleted the parquet-support branch July 29, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[FEA]: Add 'parquet' input file format support to deserializer.py
2 participants