Have conda-build test cuml installation #764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dagardner-nv in #758 you added cuml to the development environment. since then, @mdemoret-nv mentioned installing cuml as part of the test environment rather than the development environment, which I've done in this pr. Any thoughts on this? |
I need to rework my PR a bit. We don't need cuml directly in morpheus, but we do need to pin some of our deps such that users are able to install cuml after the fact without breaking the env. I like the idea of having it in the test container. |
dagardner-nv
approved these changes
Mar 20, 2023
Merged
rapids-bot bot
pushed a commit
that referenced
this pull request
Mar 21, 2023
the conda-build specific fixes from #764 Authors: - Christopher Harris (https://github.com/cwharris) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) - David Gardner (https://github.com/dagardner-nv) URL: #783
mdemoret-nv
approved these changes
Mar 22, 2023
2 tasks
… conda-build-fixes
… conda-build-fixes
… conda-build-fixes
cwharris
changed the title
… conda-build-fixes
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
contributes to #706, as the base container for devcontainer will also be used for the ci container.