Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CLI parsing of C++ enum values #676

Merged
8 commits merged into from
Feb 13, 2023
Merged

Fix CLI parsing of C++ enum values #676

8 commits merged into from
Feb 13, 2023

Commits on Feb 7, 2023

  1. Unittest to catch issue nv-morpheus#675

    @dagardner-nv
    dagardner-nv committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    e4fdf76 View commit details
    Browse the repository at this point in the history

  2. Rename test

    @dagardner-nv
    dagardner-nv committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    9fd16cb View commit details
    Browse the repository at this point in the history

  3. Fix cli pasring of pybind11 enum class. 

    C++ enums exposed by pybind11 are not subclasses of enum.Enum, but
instead are enum-work-alikes.

In additon to this the pybind11 enum keys are strings.
    @dagardner-nv
    dagardner-nv committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    5da6b3e View commit details
    Browse the repository at this point in the history

  4. Fix handling of python enums

    @dagardner-nv
    dagardner-nv committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    81b3793 View commit details
    Browse the repository at this point in the history

  5. fix test

    @dagardner-nv
    dagardner-nv committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    05b9c67 View commit details
    Browse the repository at this point in the history

  6. Verify filter source

    @dagardner-nv
    dagardner-nv committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    a3bbdad View commit details
    Browse the repository at this point in the history

  7. remove unused import

    @dagardner-nv
    dagardner-nv committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    185bbd1 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2023

  1. Unify the enum handling to work for both python and pybind11 types

    @mdemoret-nv
    mdemoret-nv committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    657c7c6 View commit details
    Browse the repository at this point in the history