Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt matx v0.3.0 #667

Merged
merged 54 commits into from
Feb 22, 2023
Merged

Adopt matx v0.3.0 #667

merged 54 commits into from
Feb 22, 2023

Commits on Feb 1, 2023

  1. wip

    @dagardner-nv
    dagardner-nv committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    134411b View commit details
    Browse the repository at this point in the history

  2. WIP - still not building, but less errors

    @dagardner-nv
    dagardner-nv committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    0b18a3a View commit details
    Browse the repository at this point in the history

  3. Building now

    @dagardner-nv
    dagardner-nv committed Feb 1, 2023
    Configuration menu
    Copy the full SHA
    8c46983 View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2023

  1. I ran into a problem where newer versions of MatX ignore stride value… 

    …s for

1d tensors. Because of this I worked-around the issue by performing an
extra transpose at the end.
    @dagardner-nv
    dagardner-nv committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    5d9540f View commit details
    Browse the repository at this point in the history

  2. cleanup

    @dagardner-nv
    dagardner-nv committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    f714dc8 View commit details
    Browse the repository at this point in the history

  3. Make rmm_tensor publicly visible to allow for unittests

    @dagardner-nv
    dagardner-nv committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    ae5de04 View commit details
    Browse the repository at this point in the history

  4. Add test for cast

    @dagardner-nv
    dagardner-nv committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    4d85891 View commit details
    Browse the repository at this point in the history

  5. Add test for the as_type method

    @dagardner-nv
    dagardner-nv committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    20db648 View commit details
    Browse the repository at this point in the history

  6. Test for threshold which is currently failing

    @dagardner-nv
    dagardner-nv committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    52fd0b7 View commit details
    Browse the repository at this point in the history

  7. Separate the by row test, to help narrow in on the bit thats failing

    @dagardner-nv
    dagardner-nv committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    db7fed5 View commit details
    Browse the repository at this point in the history

  8. Fix allocation issue

    @dagardner-nv
    dagardner-nv committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    22cdc17 View commit details
    Browse the repository at this point in the history

  9. Misc cleanups

    @dagardner-nv
    dagardner-nv committed Feb 3, 2023
    Configuration menu
    Copy the full SHA
    4f15132 View commit details
    Browse the repository at this point in the history

Commits on Feb 6, 2023

  1. First pass at re-factor to use slices

    @dagardner-nv
    dagardner-nv committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    eb68733 View commit details
    Browse the repository at this point in the history

  2. Fix weird parsing error

    @dagardner-nv
    dagardner-nv committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    ee2dbde View commit details
    Browse the repository at this point in the history

  3. Pickup updated utilities commit for new matx

    @dagardner-nv
    dagardner-nv committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    4d4b201 View commit details
    Browse the repository at this point in the history

  4. Fix bug where the model's max batch size would split inference inputs… 

    … mapping back

to the same source row in the dataframe.

ex:
model max batch = 4
seq_ids = [0, 0, 0, 1, 1, 2, 3, 3]

Would cause the inference inputs for dataframe row 1
to occurr in two non-adjacent batches.

This is a non-ideal fix as this doesn't handle the case where the inference
input is so large that it spans more rows than the model's max batch size.
    @dagardner-nv
    dagardner-nv committed Feb 6, 2023
    Configuration menu
    Copy the full SHA
    2ac19db View commit details
    Browse the repository at this point in the history

Commits on Feb 7, 2023

  1. Add dcheck to ensure we don't go past the bounds for the output buffer

    @dagardner-nv
    dagardner-nv committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    9f85081 View commit details
    Browse the repository at this point in the history

  2. Fix bug where the model's max batch size would split inference inputs… 

    … mapping back

to the same source row in the dataframe.

ex:
model max batch = 4
seq_ids = [0, 0, 0, 1, 1, 2, 3, 3]

Would cause the inference inputs for dataframe row 1
to occurr in two non-adjacent batches.

This is a non-ideal fix as this doesn't handle the case where the inference
input is so large that it spans more rows than the model's max batch size.
    @dagardner-nv
    dagardner-nv committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    a152a0b View commit details
    Browse the repository at this point in the history

  3. wip

    @dagardner-nv
    dagardner-nv committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    b76504a View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2023

  1. Merge branch 'branch-23.03' into david-fix-triton-mini-batch

    @dagardner-nv
    dagardner-nv committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    6d6b167 View commit details
    Browse the repository at this point in the history

  2. temp skip test

    @dagardner-nv
    dagardner-nv committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    ebbd900 View commit details
    Browse the repository at this point in the history

  3. Revert partial fix

    @dagardner-nv
    dagardner-nv committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    ada2547 View commit details
    Browse the repository at this point in the history

  4. Move duplicated method for computing the element count of a tensor ba… 

    …sed on the shape to a method in TensorUtils
    @dagardner-nv
    dagardner-nv committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    62f90af View commit details
    Browse the repository at this point in the history

  5. wip, trying to break up current method to make it digestable

    @dagardner-nv
    dagardner-nv committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    4965e64 View commit details
    Browse the repository at this point in the history

  6. wip, trying to break up current method to make it digestable

    @dagardner-nv
    dagardner-nv committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    ac13361 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2023

  1. wip

    @dagardner-nv
    dagardner-nv committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    d877b58 View commit details
    Browse the repository at this point in the history

  2. wip

    @dagardner-nv
    dagardner-nv committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    025c508 View commit details
    Browse the repository at this point in the history

  3. First pass at bugfix and refactor

    @dagardner-nv
    dagardner-nv committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    ba9f20a View commit details
    Browse the repository at this point in the history

  4. Use the mapped name

    @dagardner-nv
    dagardner-nv committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    ba9a372 View commit details
    Browse the repository at this point in the history

  5. remove temporary skip on failing test

    @dagardner-nv
    dagardner-nv committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    38f7f89 View commit details
    Browse the repository at this point in the history

  6. Formatting

    @dagardner-nv
    dagardner-nv committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    644d192 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'branch-23.03' into david-matx-v0.3.0-317

    @dagardner-nv
    dagardner-nv authored Feb 9, 2023
    Configuration menu
    Copy the full SHA
    d4e7220 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'david-matx-v0.3.0-317' of github.com:dagardner-nv/Morph… 

    …eus into david-matx-v0.3.0-317
    @dagardner-nv
    dagardner-nv committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    92e55d9 View commit details
    Browse the repository at this point in the history

  9. Update tests for DType changes

    @dagardner-nv
    dagardner-nv committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    15b4c79 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'david-fix-triton-mini-batch' into david-matx-v0.3.0-317-p3

    @dagardner-nv
    dagardner-nv committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    2b212d5 View commit details
    Browse the repository at this point in the history

  11. Merge branch 'branch-23.03' into david-fix-triton-mini-batch

    @dagardner-nv
    dagardner-nv committed Feb 9, 2023
    Configuration menu
    Copy the full SHA
    104480e View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2023

  1. Formatting

    @dagardner-nv
    dagardner-nv committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    741ae40 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2023

  1. Merge branch 'branch-23.03' into david-fix-triton-mini-batch

    @dagardner-nv
    dagardner-nv authored Feb 14, 2023
    Configuration menu
    Copy the full SHA
    33b4ea8 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'branch-23.03' into david-matx-v0.3.0-317

    @dagardner-nv
    dagardner-nv committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    9d0e28b View commit details
    Browse the repository at this point in the history

  3. Update submodules

    @dagardner-nv
    dagardner-nv committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    1b7fa5f View commit details
    Browse the repository at this point in the history

  4. Revert "Update submodules" 

    This reverts commit 1b7fa5f.
    @dagardner-nv
    dagardner-nv committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    8989a51 View commit details
    Browse the repository at this point in the history

  5. Adopt fix for build_and_push.sh

    @dagardner-nv
    dagardner-nv committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    30f958b View commit details
    Browse the repository at this point in the history

  6. Add cuda-nvtx to driver build, needed for matx-0.3.0

    @dagardner-nv
    dagardner-nv committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    b31c221 View commit details
    Browse the repository at this point in the history

  7. Formatting fix

    @dagardner-nv
    dagardner-nv committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    ebfa5a1 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2023

  1. Merge branch 'branch-23.03' into david-matx-v0.3.0-317

    @dagardner-nv
    dagardner-nv authored Feb 15, 2023
    Configuration menu
    Copy the full SHA
    2835777 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'branch-23.03' into david-fix-triton-mini-batch

    @dagardner-nv
    dagardner-nv authored Feb 15, 2023
    Configuration menu
    Copy the full SHA
    950f4e6 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2023

  1. Merge branch 'branch-23.03' into david-fix-triton-mini-batch

    @dagardner-nv
    dagardner-nv authored Feb 16, 2023
    Configuration menu
    Copy the full SHA
    868ed1a View commit details
    Browse the repository at this point in the history

  2. Revert get_buffer method

    @dagardner-nv
    dagardner-nv committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    ac3cb69 View commit details
    Browse the repository at this point in the history

  3. Add second map to hold output buffers

    @dagardner-nv
    dagardner-nv committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    b38674a View commit details
    Browse the repository at this point in the history

  4. Formatting fix

    @dagardner-nv
    dagardner-nv committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    ffc9aa0 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'branch-23.03' into david-matx-v0.3.0-317

    @dagardner-nv
    dagardner-nv authored Feb 16, 2023
    Configuration menu
    Copy the full SHA
    7bf5c3f View commit details
    Browse the repository at this point in the history

Commits on Feb 17, 2023

  1. Merge branch 'david-fix-triton-mini-batch' into david-matx-v0.3.0-317

    @dagardner-nv
    dagardner-nv committed Feb 17, 2023
    Configuration menu
    Copy the full SHA
    3f65fdc View commit details
    Browse the repository at this point in the history

Commits on Feb 18, 2023

  1. Format fix

    @dagardner-nv
    dagardner-nv committed Feb 18, 2023
    Configuration menu
    Copy the full SHA
    8cfd470 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2023

  1. Merge branch 'branch-23.03' into david-matx-v0.3.0-317

    @dagardner-nv
    dagardner-nv authored Feb 22, 2023
    Configuration menu
    Copy the full SHA
    fabd29d View commit details
    Browse the repository at this point in the history