Control MonitorStage output with the log-level #659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagardner-nv
added
non-breaking
dagardner-nv
added
breaking
mdemoret-nv
approved these changes
Feb 6, 2023
…r-nv/Morpheus into david-monitor-stage-logging-553
|
/merge |
ghost
merged commit
jjacobelli
pushed a commit
to jjacobelli/Morpheus
that referenced
this pull request
Mar 7, 2023
* Add new `log_level` constructor argument to `MonitorStage` * `MonitorStage` only adds itself to the MRC pipeline if the `morpheus.stages.general.monitor_stage` logger is configured at or below `log_level` Allows pipeline authors to control the inclusion of progress output via the Morpheus logger. By default monitor stage output will only be present for `INFO` level and below. Marking this as a breaking change for pipelines authors who expect to see monitor stage output when configuring Morpheus with `WARNING` level and higher. Requires nv-morpheus#676 to be merged, and forward-merged into 23.03 first. fixes nv-morpheus#553 Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Michael Demoret (https://github.com/mdemoret-nv) URL: nv-morpheus#659
rapids-bot bot
pushed a commit
that referenced
this pull request
Apr 24, 2024
* PR #659 inadvertently excluded the monitor stage from several of the end-to-end pipeline tests. * Adds an environment variable `MORPHEUS_MONITOR_ALWAYS_ENABLED` which when set, will force the monitor stage to always be enabled. * Adds an auto-use fixture `monitor_stage_always_enabled` which ensures the environment variable is set & present. Requires nv-morpheus/MRC#473 to be merged first ## By Submitting this PR I confirm: - I am familiar with the [Contributing Guidelines](https://github.com/nv-morpheus/Morpheus/blob/main/docs/source/developer_guide/contributing.md). - When the PR is ready for review, new or existing tests cover these changes. - When the PR is ready for review, the documentation is up to date with these changes. Authors: - David Gardner (https://github.com/dagardner-nv) Approvers: - Christopher Harris (https://github.com/cwharris) - Michael Demoret (https://github.com/mdemoret-nv) URL: #1629
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
log_levelconstructor argument toMonitorStageMonitorStageonly adds itself to the MRC pipeline if themorpheus.stages.general.monitor_stagelogger is configured at or belowlog_levelAllows pipeline authors to control the inclusion of progress output via the Morpheus logger. By default monitor stage output will only be present for
INFOlevel and below.Marking this as a breaking change for pipelines authors who expect to see monitor stage output when configuring Morpheus with
WARNINGlevel and higher.Requires #676 to be merged, and forward-merged into 23.03 first.
fixes #553