Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Silence build warnings when building rabbitmq example #658

Merged
6 commits merged into from
Feb 1, 2023
Merged

Silence build warnings when building rabbitmq example #658

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
68e2fd3
wip - not working
dagardner-nv Jan 31, 2023
8a29159
Adopt unreleased cmake fixes in librabbitmq
dagardner-nv Jan 31, 2023
249ca55
Fix include paths
dagardner-nv Jan 31, 2023
5741258
Silence warnings coming from rabbitmq
dagardner-nv Jan 31, 2023
8090c05
Go back to a shallow checkout
dagardner-nv Jan 31, 2023
731b097
Merge branch 'branch-23.03' into david-build-warnings-471
dagardner-nv Jan 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion examples/developer_guide/4_rabbitmq_cpp_stage/cmake/Configure_SimpleAmqpClient.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,18 @@ function(find_and_configure_SimpleAmqpClient version)
GIT_REPOSITORY https://github.com/alanxz/SimpleAmqpClient
GIT_TAG "v${version}"
GIT_SHALLOW TRUE
OPTIONS "Rabbitmqc_INCLUDE_DIR ${rabbitmq_SOURCE_DIR}/librabbitmq"
OPTIONS "Rabbitmqc_INCLUDE_DIR ${rabbitmq_SOURCE_DIR}/include"
"Rabbitmqc_LIBRARY ${rabbitmq_BINARY_DIR}/librabbitmq/librabbitmq.so"
"BUILD_API_DOCS OFF"
"BUILD_SHARED_LIBS OFF"
)

# Needed to pick up the generated export.h
target_include_directories(SimpleAmqpClient PUBLIC "${rabbitmq_BINARY_DIR}/include")

# Suppress #warning deprecation messages from rabbitmq
target_compile_options(SimpleAmqpClient PRIVATE -Wno-cpp)

endfunction()

find_and_configure_SimpleAmqpClient(${SIMPLE_AMQP_CLIENT_VERSION})
5 changes: 4 additions & 1 deletion examples/developer_guide/4_rabbitmq_cpp_stage/cmake/Configure_rabbitmq.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@ function(find_and_configure_rabbitmq version)

list(APPEND CMAKE_MESSAGE_CONTEXT "rabbitmq")

# Commit 7fa7b0b contains unreleased cmake fixes which currently only exist in the master branch of the repo.
# https://github.com/alanxz/rabbitmq-c/issues/740

rapids_cpm_find(rabbitmq ${version}
GLOBAL_TARGETS
rabbitmq rabbitmq::rabbitmq
Expand All @@ -28,7 +31,7 @@ function(find_and_configure_rabbitmq version)
${PROJECT_NAME}-exports
CPM_ARGS
GIT_REPOSITORY https://github.com/alanxz/rabbitmq-c
GIT_TAG "v${version}"
GIT_TAG 7fa7b0b
GIT_SHALLOW TRUE
OPTIONS "BUILD_EXAMPLES OFF"
"BUILD_TESTING OFF"
Expand Down