Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update DFPMLFlowModelWriterStage to no longer save mean and std metrics #605

Merged
1 commit merged into from
Jan 13, 2023

Conversation

efajardo-nv
Copy link
Contributor

@efajardo-nv efajardo-nv commented Jan 11, 2023

dfencoder is being updated in this PR to no longer store mean and std in the AutoEncoder model. This will cause an error in DFPMLFlowModelWriterStage where it tries to publish mean and std as metrics to MLflow. This PR updates DFPMLFlowModelWriterStage to no longer publish the metrics since they don't appear be used in Morpheus anymore.

@efajardo-nv efajardo-nv added non-breaking Non-breaking change improvement Improvement to existing functionality labels Jan 11, 2023
@hsin-c
Copy link
Contributor

hsin-c commented Jan 11, 2023

lgtm

@efajardo-nv efajardo-nv marked this pull request as ready for review January 13, 2023 15:31
@efajardo-nv efajardo-nv requested a review from a team as a code owner January 13, 2023 15:31
@mdemoret-nv
Copy link
Contributor

/merge

@ghost ghost merged commit af41d35 into nv-morpheus:branch-23.01 Jan 13, 2023
@efajardo-nv efajardo-nv deleted the mlflow_remove_mean_std branch July 29, 2024 21:06
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement to existing functionality non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants