Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MultiInferenceMessage & MultiResponseMessage share a new base class #419

Merged
25 commits merged into from
Nov 4, 2022
Merged

MultiInferenceMessage & MultiResponseMessage share a new base class #419

25 commits merged into from
Nov 4, 2022

Conversation

dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented Oct 27, 2022 •
edited
Loading

  • MultiInferenceMessage & MultiResponseMessage now inherit a new class MultiTensorMessage reducing the duplicated code in each
  • MultiResponseProbsMessage class now uses ResponseMemoryProbs
  • Add missing docstrings
  • Common CSV & Json reading code moved to deserializers.[hpp|cpp]

fixes #313
fixes #311

@dagardner-nv dagardner-nv added non-breaking Non-breaking change improvement Improvement to existing functionality 2 - In Progress labels Oct 27, 2022
@dagardner-nv dagardner-nv requested review from a team as code owners October 27, 2022 16:25
mdemoret-nv
mdemoret-nv requested changes Oct 28, 2022
View reviewed changes
Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only changes I would like to see is some of the implementations moved to a CPP files. I made 1 comment but there are many occurances

morpheus/_lib/include/morpheus/messages/multi_response.hpp Outdated Show resolved Hide resolved
morpheus/_lib/src/stages/file_source.cpp Show resolved Hide resolved
mdemoret-nv
mdemoret-nv requested changes Nov 2, 2022
View reviewed changes
Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of redundant changes regarding static pointer casts. If that doesnt work out, disregard them all.

morpheus/_lib/include/morpheus/messages/multi_inference.hpp Outdated Show resolved Hide resolved
morpheus/_lib/include/morpheus/messages/multi_response.hpp Outdated Show resolved Hide resolved
morpheus/_lib/include/morpheus/messages/multi_tensor.hpp Show resolved Hide resolved
morpheus/_lib/src/messages/multi_inference.cpp Outdated Show resolved Hide resolved
morpheus/_lib/src/messages/multi_inference_fil.cpp Outdated Show resolved Hide resolved
morpheus/_lib/src/messages/multi_response_probs.cpp Outdated Show resolved Hide resolved
morpheus/_lib/src/messages/multi_tensor.cpp Outdated Show resolved Hide resolved
morpheus/_lib/src/messages/multi_tensor.cpp Outdated Show resolved Hide resolved
morpheus/_lib/src/messages/multi_tensor.cpp Outdated Show resolved Hide resolved
morpheus/_lib/src/stages/triton_inference.cpp Outdated Show resolved Hide resolved
mdemoret-nv
mdemoret-nv approved these changes Nov 3, 2022
View reviewed changes
Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

morpheus/_lib/src/messages/memory/response_memory_probs.cpp Show resolved Hide resolved
morpheus/_lib/src/messages/multi_response.cpp Outdated Show resolved Hide resolved
morpheus/_lib/src/messages/multi_response_probs.cpp Outdated Show resolved Hide resolved
dagardner-nv and others added 5 commits November 4, 2022 08:11
@dagardner-nv @mdemoret-nv
Update morpheus/_lib/src/messages/memory/response_memory_probs.cpp
57ae4f7 
Co-authored-by: Michael Demoret <42954918+mdemoret-nv@users.noreply.github.com>
@dagardner-nv @mdemoret-nv
Update morpheus/_lib/src/messages/multi_response.cpp
a754a92 
Co-authored-by: Michael Demoret <42954918+mdemoret-nv@users.noreply.github.com>
@dagardner-nv @mdemoret-nv
Update morpheus/_lib/src/messages/multi_response_probs.cpp
1ad4f9c 
Co-authored-by: Michael Demoret <42954918+mdemoret-nv@users.noreply.github.com>
@dagardner-nv
Merge branch 'branch-22.11' into david-multi-messages
41162de
@dagardner-nv
Clang formatting fix
a8b46fc
@mdemoret-nv
Copy link
Contributor

@gpucibot merge

@ghost ghost merged commit 598f356 into nv-morpheus:branch-22.11 Nov 4, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdemoret-nv mdemoret-nv mdemoret-nv approved these changes

Assignees
No one assigned
Labels
improvement Improvement to existing functionality non-breaking Non-breaking change
Projects
Morpheus Boards
Archived in project
Milestone
No milestone
2 participants
@dagardner-nv @mdemoret-nv