Resolves #350 -- Adds support for segmenting LinearPipelines #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drobison00
added
enhancement
drobison00
added
non-breaking
dagardner-nv
approved these changes
Sep 27, 2022
There was a problem hiding this comment.
Looks good.
I know this really isn't part of your diff... but I noticed that in Pipeline.build we call segment_graph.nodes() a couple of times, maybe we should save this to a local variable.
If we assume the number of nodes in any segment to be smallish and/or if this call is cheap then maybe this isn't important.
Co-authored-by: David Gardner <96306125+dagardner-nv@users.noreply.github.com>
Remove changes that came in from another MR.
Remove changes from another MR
|
@gpucibot merge |
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LinearPipeline,add_segment_boundary([data_type], [is_shared_pointer]), which will create an egress stage and connected to the most recent linear stage, and an ingress source stage in a new segment. Atbuild, these stages will be connected.Known issue here: [BUG] Extension libraries compiled with pybind11 don't have cpptype visibility via get_internals MRC#176 : Currently specifying the data type has no effect and all underlying objects will utilize the default PythonObject path. This is due to the method we were using to match the
cpptypeof a wrapped python object to the cpptype of an Ingress/EgressPort adapter. Once we're able to add an out of band path for type detection/storage this will be resolve.Pipelineto be segment aware, and makes the necessary updates to Pipeline internals to handle the changes.visualize(..)