Add jupyter to the main Dockerfile (NGC) #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdmack
added
non-breaking
drobison00
approved these changes
Sep 26, 2022
|
@drobison00 add them to the conda env I suppose via the morpheus recipe. I'll commit for now and see what @mdemoret-nv thinks later. |
|
@gpucibot merge |
ghost
merged commit
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Production DFP has its own Dockerfile but for NGC publishing I would prefer to just have one omnibus image there which can run the classic pipeline as well as prod DFP inference and training.
Helm instructions are WIP and owed by me to @dagardner-nv #368