Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mlflow update 2209 #367

Merged
11 commits merged into from
Sep 22, 2022
Merged

Mlflow update 2209 #367

11 commits merged into from
Sep 22, 2022

Conversation

pdmack
Copy link
Contributor

@pdmack pdmack commented Sep 20, 2022

Some changes in support of production DFP and also image hygiene

@pdmack pdmack added dependencies Pull requests that update a dependency file non-breaking Non-breaking change 3 - Ready for Review labels Sep 20, 2022
@pdmack pdmack requested a review from a team as a code owner September 20, 2022 15:24
@pdmack pdmack added the improvement Improvement to existing functionality label Sep 20, 2022
@pdmack
Copy link
Contributor Author

pdmack commented Sep 20, 2022

ok to test

Copy link
Contributor

@dagardner-nv dagardner-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@efajardo-nv
Copy link
Contributor

efajardo-nv commented Sep 20, 2022

@pdmack pr changes look good but noticed a couple other updates we need to add:

  • readme: tags from docker build and docker run don’t match
  • git lfs needs to be installed on image

should i create a separate pr for these or do you want to add this pr?

Copy link
Contributor

@raykallen raykallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pdmack
Copy link
Contributor Author

pdmack commented Sep 22, 2022

@gpucibot merge

@ghost ghost merged commit bc791ea into nv-morpheus:branch-22.09 Sep 22, 2022
@pdmack pdmack deleted the mlflow-update-2209 branch September 30, 2022 16:26
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file improvement Improvement to existing functionality non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants