Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QSG updates for data dir #302

Merged
1 commit merged into from
Jul 25, 2022
Merged

QSG updates for data dir #302

1 commit merged into from
Jul 25, 2022

Conversation

pdmack
Copy link
Contributor

@pdmack pdmack commented Jul 25, 2022

./morpheus/data/' -> data/` wherever we load vocab files, etc.

Fixes #301

@pdmack
QSG updates for data dir
5abc896 
`./morpheus/data/' -> `data/` wherever we load vocab files, etc.

Fixes #301
@pdmack pdmack added non-breaking Non-breaking change doc Improvements or additions to documentation 3 - Ready for Review labels Jul 25, 2022
@pdmack pdmack requested a review from a team as a code owner July 25, 2022 16:53
cwharris
cwharris approved these changes Jul 25, 2022
View reviewed changes
Copy link
Contributor

@cwharris cwharris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bsuryadevara
bsuryadevara approved these changes Jul 25, 2022
View reviewed changes
Copy link
Contributor

@bsuryadevara bsuryadevara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdemoret-nv
Copy link
Contributor

@gpucibot merge

@ghost ghost merged commit 7f63821 into branch-22.08 Jul 25, 2022
@ghost ghost deleted the pdmack-patch-2 branch July 25, 2022 18:06
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwharris cwharris cwharris approved these changes

@bsuryadevara bsuryadevara bsuryadevara approved these changes

@mdemoret-nv mdemoret-nv mdemoret-nv approved these changes

Assignees

@bsuryadevara bsuryadevara

Labels
doc Improvements or additions to documentation non-breaking Non-breaking change
Projects
Morpheus Boards
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DOC] QSG requires updates for data dir location
4 participants
@pdmack @mdemoret-nv @cwharris @bsuryadevara