Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IWYU CI integration for Morpheus #287

Merged
44 commits merged into from
Aug 22, 2022
Merged

Conversation

dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented Jul 18, 2022

  • Add IWYU check to CI
  • Fix includes to pass
  • Rename deserialization.hpp to deserialize.hpp such that the filename matches the associated cpp & python file names. This also causes IWYU to identify the header as being associated.

@dagardner-nv dagardner-nv added non-breaking Non-breaking change improvement Improvement to existing functionality DO NOT MERGE PR should not be merged; see PR for details 2 - In Progress labels Jul 18, 2022
@dagardner-nv dagardner-nv requested review from a team as code owners July 18, 2022 22:41
@dagardner-nv dagardner-nv changed the base branch from branch-22.08 to branch-22.09 August 15, 2022 21:54
@dagardner-nv dagardner-nv changed the title Draft: iwyu IWYU CI integration for Morpheus Aug 15, 2022
@dagardner-nv dagardner-nv added 3 - Ready for Review and removed DO NOT MERGE PR should not be merged; see PR for details 2 - In Progress labels Aug 15, 2022
Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@mdemoret-nv
Copy link
Contributor

@gpucibot merge

@ghost ghost merged commit 2cf7e10 into nv-morpheus:branch-22.09 Aug 22, 2022
@dagardner-nv dagardner-nv mentioned this pull request Oct 3, 2022
@dagardner-nv dagardner-nv deleted the david-iwyu branch February 12, 2024 23:21
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement to existing functionality non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants