Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure TableInfo only appears in one lib #273

Merged
1 commit merged into from
Jul 26, 2022

Conversation

dagardner-nv
Copy link
Contributor

  • Removes table_info.cpp from morpheus.cmake
  • Sets visibility on the TableInfo.as_py_object method, this was showing up as undefined in libmorpheus.so.

I tried just setting #pragma GCC visibility push(default) at the top of the class definition, but this didn't work, according to the gcc docs this is intentional:

In C++, ‘#pragma GCC visibility’ affects only namespace-scope declarations. Class members and template specializations are not affected; if you want to override the visibility for a particular member or instantiation, you must use an attribute.
https://gcc.gnu.org/onlinedocs/gcc-4.9.2/gcc/Visibility-Pragmas.html

fixes #271

@dagardner-nv dagardner-nv requested a review from a team as a code owner July 13, 2022 23:56
@dagardner-nv dagardner-nv added non-breaking Non-breaking change improvement Improvement to existing functionality 3 - Ready for Review labels Jul 13, 2022
Copy link
Contributor

@drobison00 drobison00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable.

@pdmack
Copy link
Contributor

pdmack commented Jul 25, 2022

LGTM, no failures from a file smoke test

(morpheus) root@sdk-cli-sdk1:/workspace# nm -C /opt/conda/envs/morpheus/lib/python3.8/site-packages/morpheus/_lib/libmorpheus.so | grep table_info.cpp
(morpheus) root@sdk-cli-sdk1:/workspace# nm -C /opt/conda/envs/morpheus/lib/python3.8/site-packages/morpheus/_lib/libmorpheus_utils.so | grep table_info.cpp
00000000000332f0 t _GLOBAL__sub_I_table_info.cpp

Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdemoret-nv
Copy link
Contributor

@gpucibot merge

@ghost ghost merged commit db46244 into nv-morpheus:branch-22.08 Jul 26, 2022
@dagardner-nv dagardner-nv deleted the david-table-info-builds branch February 12, 2024 23:21
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvement to existing functionality non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG] table_info appears in two different libs
4 participants