Ensure TableInfo only appears in one lib #273
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
table_info.cpp
frommorpheus.cmake
TableInfo.as_py_object
method, this was showing up as undefined inlibmorpheus.so
.I tried just setting
#pragma GCC visibility push(default)
at the top of the class definition, but this didn't work, according to the gcc docs this is intentional:fixes #271