Fix 22.06 style checks #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdemoret-nv
added
non-breaking
|
@gpucibot merge |
ghost
merged commit 
drobison00
reviewed
Jun 30, 2022
| """ | ||
|
|
||
| import argparse |
There was a problem hiding this comment.
why is this on a line by itself?
| #since inference is done, add the original columns back so the output will be the same as the input format | ||
| #X_val['ts_anomaly']=X_val_original['ts_anomaly'] | ||
| # since inference is done, add the original columns back so the output will be the same as the input format | ||
| # X_val['ts_anomaly']=X_val_original['ts_anomaly'] |
| timeobj = list(map(stript, timearr)) | ||
| hs = list(map(date2min, timeobj)) | ||
| n, bins = cp.histogram(cp.array(hs), bins = cp.arange(0, max(hs))) | ||
| n, _ = cp.histogram(cp.array(hs), bins=cp.arange(0, max(hs))) |
There was a problem hiding this comment.
Maybe a nitpick, but I'd like to see all these stacked lines broken out a bit into blocks of logical steps or sub functions.
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes style checks preventing #237 from passing