Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use git version 2.35.3 in release build #224

Merged
1 commit merged into from
Jun 28, 2022
Merged

Use git version 2.35.3 in release build #224

1 commit merged into from
Jun 28, 2022

Conversation

mdemoret-nv
Copy link
Contributor

@mdemoret-nv mdemoret-nv commented Jun 27, 2022 •
edited
Loading

Forces the docker build to use git version 2.35.3. Otherwise conda build breaks during release container builds.

Fixes #223

@mdemoret-nv mdemoret-nv added bug Something isn't working non-breaking Non-breaking change labels Jun 27, 2022
@mdemoret-nv mdemoret-nv requested a review from a team as a code owner June 27, 2022 23:50
@pdmack
Copy link
Contributor

pdmack commented Jun 28, 2022

LGTM

#27 exporting to image
#27 exporting layers
#27 exporting layers 49.8s done
#27 writing image sha256:491f758eebea9a7eb12c80e87717373e801eead5c6f971b08806218b21a9d71c done
#27 naming to nvcr.io/nvidia/morpheus/morpheus:v22.04.00-runtime done
#27 DONE 49.8s

bsuryadevara
bsuryadevara approved these changes Jun 28, 2022
View reviewed changes
Copy link
Contributor

@bsuryadevara bsuryadevara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdemoret-nv
Copy link
Contributor Author

@gpucibot merge

@ghost ghost merged commit 8a40730 into nv-morpheus:branch-22.06 Jun 28, 2022
@mdemoret-nv mdemoret-nv deleted the mdd_fix-release-container-git branch June 28, 2022 01:37
@mdemoret-nv mdemoret-nv mentioned this pull request Jun 28, 2022
Closed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsuryadevara bsuryadevara bsuryadevara approved these changes

Assignees
No one assigned
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mdemoret-nv @pdmack @bsuryadevara