-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include C++ Unittests in CI #135
Conversation
This reverts commit 33daa7a.
Co-authored-by: Christopher Harris <xixonia@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this PR needs to be updated from branch-22.06
. And I have one suggestion to avoid manipulating the RPATH depending on the MORPHEUS_INPLACE_BUILD
…ase branch Rather than transfer individual tests, transfer the wheel, and the conda env without morpheus installed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new artifacts look good
@gpucibot merge |
Adds test_libmorpheus to the wheel component.
When installing into build/wheel and
MORPHEUS_PYTHON_INPLACE_BUILD=OFF
set the rpath to the site packages install dir. Even though we aren't installing the test into site-packages we do need it to use the installed libs.The version of
test_libmorpheus.x
in the build dir will uselibmorpheus_utils.so
from the build dir,while the version of
test_libmorpheus.x
installed intobuild/wheel
will uselibmorpheus_utils.so
from${Python3_SITELIB}/morpheus/_lib
which means that the test will fail unless the python package has been installed.Closes #133