Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include C++ Unittests in CI #135

Merged
331 commits merged into from
Jun 17, 2022
Merged

Conversation

dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented May 31, 2022

Adds test_libmorpheus to the wheel component.

When installing into build/wheel and MORPHEUS_PYTHON_INPLACE_BUILD=OFF set the rpath to the site packages install dir. Even though we aren't installing the test into site-packages we do need it to use the installed libs.

The version of test_libmorpheus.x in the build dir will use libmorpheus_utils.so from the build dir,
while the version of test_libmorpheus.x installed into build/wheel will use libmorpheus_utils.so from ${Python3_SITELIB}/morpheus/_lib which means that the test will fail unless the python package has been installed.

Closes #133

@dagardner-nv dagardner-nv added the feature request New feature or request label May 31, 2022
CMakeLists.txt Outdated Show resolved Hide resolved
ci/scripts/gitutils.py Outdated Show resolved Hide resolved
morpheus/_lib/tests/CMakeLists.txt Outdated Show resolved Hide resolved
ci/scripts/jenkins/test.sh Show resolved Hide resolved
dagardner-nv and others added 2 commits June 1, 2022 11:44
Co-authored-by: Christopher Harris <xixonia@gmail.com>
Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this PR needs to be updated from branch-22.06. And I have one suggestion to avoid manipulating the RPATH depending on the MORPHEUS_INPLACE_BUILD

ci/scripts/get_merge_target.py Outdated Show resolved Hide resolved
morpheus/_lib/tests/CMakeLists.txt Outdated Show resolved Hide resolved
Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new artifacts look good

@mdemoret-nv
Copy link
Contributor

@gpucibot merge

@ghost ghost merged commit 83cf138 into nv-morpheus:branch-22.06 Jun 17, 2022
@dagardner-nv dagardner-nv deleted the david-cpp-ci branch February 12, 2024 23:20
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Additional functionality added to an existing feature feature request New feature or request non-breaking Non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEA] Integrate C++ tests into CI
3 participants