-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eliminate redundant code blocks in modules and stages #1123
Eliminate redundant code blocks in modules and stages #1123
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Glad to see this consolidation!
Changed to in progress. Fixing broken tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few general items:
- Move the controllers out of the
utils
directory and to their own directorymorpheus/controllers
- Can you verify that there are no other modules that do not use a controller?
- Would it make more sense for some of the stages to just use the module
examples/digital_fingerprinting/production/morpheus/dfp/stages/dfp_file_to_df.py
Outdated
Show resolved
Hide resolved
examples/digital_fingerprinting/production/morpheus/dfp/stages/dfp_file_to_df.py
Outdated
Show resolved
Hide resolved
examples/digital_fingerprinting/production/morpheus/dfp/utils/model_cache.py
Outdated
Show resolved
Hide resolved
examples/digital_fingerprinting/production/morpheus/dfp/utils/model_cache.py
Outdated
Show resolved
Hide resolved
|
/ok to test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple more items. Should be good to merge once the comments are resolved.
examples/digital_fingerprinting/production/morpheus/dfp/utils/model_cache.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Michael Demoret <42954918+mdemoret-nv@users.noreply.github.com>
…eus into remove-duplicate-code
/ok to test |
/merge |
Eliminated redundant code blocks in both modules and stages, introducing controllers to enhance maintainability, and subsequently updated tests to align with these changes.
Fixed preserve columns property issue.
closes #965 #1074