Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge morpheus core spear phishing components. #1044

Merged
merged 22 commits into from
Jul 13, 2023
Merged

Merge morpheus core spear phishing components. #1044

merged 22 commits into from
Jul 13, 2023

Conversation

drobison00
Copy link
Contributor

Add Morpheus core spear phishing components.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@drobison00 drobison00 requested review from a team as code owners July 12, 2023 04:51
@drobison00 drobison00 added enhancement Additional functionality added to an existing feature non-breaking Non-breaking change improvement Improvement to existing functionality 3 - Ready for Review labels Jul 12, 2023
@drobison00 drobison00 self-assigned this Jul 12, 2023
mdemoret-nv
mdemoret-nv requested changes Jul 12, 2023
View reviewed changes
Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issues found in multiple places:

  1. Tests that expect an exception should use with pytest.raises(Exception): instead of asserting false
  2. Tests should not use global variables. Instead use nonlocal to scope each variable to a test

morpheus/_lib/src/modules/data_loader_module.cpp Show resolved Hide resolved
morpheus/_lib/src/modules/data_loader_module.cpp Outdated Show resolved Hide resolved
morpheus/loaders/__init__.py Show resolved Hide resolved
morpheus/loaders/sql_loader.py Outdated Show resolved Hide resolved
morpheus/loaders/sql_loader.py Outdated Show resolved Hide resolved
morpheus/utils/control_message_utils.py Show resolved Hide resolved
tests/modules/test_morpheus_modules.py Outdated Show resolved Hide resolved
tests/modules/test_morpheus_modules_with_pipeline.py Show resolved Hide resolved
tests/modules/test_morpheus_modules.py Outdated Show resolved Hide resolved
.gitattributes Outdated Show resolved Hide resolved
@mdemoret-nv
Copy link
Contributor

@drobison00 Make sure to link any issues that should be closed with this PR before merging

@drobison00
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit 0987dfb into nv-morpheus:branch-23.07 Jul 13, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsuryadevara bsuryadevara bsuryadevara left review comments

@mdemoret-nv mdemoret-nv mdemoret-nv approved these changes

Assignees

@drobison00 drobison00

Labels
enhancement Additional functionality added to an existing feature improvement Improvement to existing functionality non-breaking Non-breaking change
Projects
Morpheus Boards
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drobison00 @mdemoret-nv @bsuryadevara