Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation builds #1039

Merged

Conversation

dagardner-nv
Copy link
Contributor

@dagardner-nv dagardner-nv commented Jul 11, 2023

Description

  • Remove documentation-only deps from docker/conda/environments/cuda11.8_dev.yml
  • morpeus_docs cmake target removed from default build target
  • documentation deps are now installed from conda-forge not pypi
  • Set an env variable MORPHEUS_IN_SPHINX_BUILD during documentation builds allowing the code to bypass certain calls with side-effects.
  • Sphinx now treats all warnings as fatal errors.
  • Removed out of date docs/source/control_message_guide.md doc
  • Fix numerous docstring issues & broken links
  • Private symbols moved into anonymous namespaces to prevent them from being visible to doxygen.
  • CudfHelper::load() avoids calling import_morpheus___lib__cudf_helpers if MORPHEUS_IN_SPHINX_BUILD is defined.
  • morpheus/utils/nvt/mutate.py will now defined a stub annotate decorator if MORPHEUS_IN_SPHINX_BUILD is defined.
  • morpheus/utils/schema_transforms.py will avoid calling patch_numpy_dtype_registry and register_morpheus_extensions if MORPHEUS_IN_SPHINX_BUILD is defined.
  • Replace empty __alll__ declarations in __init__.py files

fixes #1028

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@dagardner-nv dagardner-nv requested a review from a team as a code owner July 11, 2023 22:40
@mdemoret-nv mdemoret-nv requested a review from a team as a code owner July 12, 2023 03:32
@dagardner-nv dagardner-nv changed the title WIP: documentation builds Fix documentation builds Jul 12, 2023
@dagardner-nv dagardner-nv added non-breaking Non-breaking change doc Improvements or additions to documentation 2 - In Progress labels Jul 12, 2023
Copy link
Contributor

@mdemoret-nv mdemoret-nv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better now. Would like to see the DFP modules added into the API, but I'll add a new issue for that later

@dagardner-nv
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit e7911f3 into nv-morpheus:branch-23.07 Jul 13, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Improvements or additions to documentation non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG]: Fix issues with Documentation CI stage
3 participants