Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move hard-coded path in E2E benchmarks to config json #1011

Merged

Conversation

efajardo-nv
Copy link
Contributor

@efajardo-nv efajardo-nv commented Jun 28, 2023

Description

  • Move hard-coded glob (inside MORPHEUS_ROOT) for CloudTrail AE training data to e2e_test_configs.json.
  • Fix CloudTrail AE training data glob to point to training data instead of validation/inference data. This will result in longer pipeline run times because training data used by pipeline will now be larger.

Fixes #1005

Checklist

[x] I am familiar with the Contributing Guidelines.
[x] New or existing tests cover these changes.
[x] The documentation is up to date with these changes.

@efajardo-nv efajardo-nv added bug Something isn't working non-breaking Non-breaking change labels Jun 28, 2023
@efajardo-nv efajardo-nv requested a review from a team as a code owner June 28, 2023 18:06
@efajardo-nv efajardo-nv changed the title Update E2E benchmarking to work outside of dev container Move hard-coded path in E2E benchmarks to config json Jun 28, 2023
@mdemoret-nv
Copy link
Contributor

/merge

@rapids-bot rapids-bot bot merged commit 343cd64 into nv-morpheus:branch-23.07 Jul 5, 2023
@mdemoret-nv mdemoret-nv deleted the cloudtrail-ae-benchmark-fix branch July 5, 2023 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[BUG]: Training dataset for test_cloudtrail_ae_e2e is hard coded
2 participants