Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GNN FSI modelcard++ #1010

Merged
merged 10 commits into from
Jun 30, 2023
Merged

GNN FSI modelcard++ #1010

merged 10 commits into from
Jun 30, 2023

Conversation

tzemicheal
Copy link
Contributor

@tzemicheal tzemicheal commented Jun 28, 2023 •
edited
Loading

Description

Add modelcard++ for the GNN FSI model.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@tzemicheal tzemicheal added non-breaking Non-breaking change doc Improvements or additions to documentation 3 - Ready for Review labels Jun 28, 2023
@tzemicheal tzemicheal requested a review from a team as a code owner June 28, 2023 17:51
@tzemicheal tzemicheal self-assigned this Jun 28, 2023
hsin-c
hsin-c requested changes Jun 29, 2023
View reviewed changes
models/model-cards/gnn-fsi-modelcard.md Outdated Show resolved Hide resolved
models/model-cards/gnn-fsi-modelcard.md Outdated Show resolved Hide resolved
models/model-cards/gnn-fsi-modelcard.md Outdated Show resolved Hide resolved
models/model-cards/gnn-fsi-modelcard.md Outdated Show resolved Hide resolved
models/model-cards/gnn-fsi-modelcard.md Outdated Show resolved Hide resolved
models/model-cards/gnn-fsi-modelcard.md Outdated Show resolved Hide resolved
models/model-cards/gnn-fsi-modelcard.md Outdated Show resolved Hide resolved
models/model-cards/gnn-fsi-modelcard.md Outdated Show resolved Hide resolved
models/model-cards/gnn-fsi-modelcard.md Outdated Show resolved Hide resolved
models/model-cards/gnn-fsi-modelcard.md Outdated Show resolved Hide resolved
@mdemoret-nv
Copy link
Contributor

@tzemicheal Please add the copyright header to the new file you added. You can automatically do this locally with python ci/scripts/copyright.py --git-modified-only --update-current-year --insert

hsin-c
hsin-c requested changes Jun 29, 2023
View reviewed changes
models/model-cards/gnn-fsi-model-card.md Outdated Show resolved Hide resolved
models/model-cards/gnn-fsi-model-card.md Outdated Show resolved Hide resolved
models/model-cards/gnn-fsi-model-card.md Outdated Show resolved Hide resolved
@hsin-c
Copy link
Contributor

hsin-c commented Jun 30, 2023

/merge

@rapids-bot rapids-bot bot merged commit 16a629b into nv-morpheus:branch-23.07 Jun 30, 2023
4 checks passed
@tzemicheal tzemicheal deleted the fsi_modelcard branch August 30, 2023 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsin-c hsin-c hsin-c approved these changes

Assignees

@tzemicheal tzemicheal

@hsin-c hsin-c

Labels
doc Improvements or additions to documentation non-breaking Non-breaking change
Projects
Morpheus Boards
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tzemicheal @mdemoret-nv @hsin-c