-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use size_t for element counts & byte sizes #1007
Merged
rapids-bot
merged 14 commits into
nv-morpheus:branch-23.07
from
dagardner-nv:david-tensorindex-size-t
Jun 28, 2023
Merged
Use size_t for element counts & byte sizes #1007
rapids-bot
merged 14 commits into
nv-morpheus:branch-23.07
from
dagardner-nv:david-tensorindex-size-t
Jun 28, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagardner-nv
added
bug
Something isn't working
breaking
Breaking change
3 - Ready for Review
labels
Jun 28, 2023
mdemoret-nv
approved these changes
Jun 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. But similar to how we have TensorIndex
, can we have a TensorSize
which we use in place of all the size_t
? Then it will be easier to update in the future if we need.
Co-authored-by: Michael Demoret <42954918+mdemoret-nv@users.noreply.github.com>
… add test to verify that we can create a tensor with a large shape
mdemoret-nv
approved these changes
Jun 28, 2023
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
TensorIndex
(int32_t
) as an index in tensors & dataframes.std::size_t
for byte & element counts (for multi-dimensional arrays/tensors).TensorIndex
for element counts for 1d tensors/arrays and things likenum_rows
.Although we can only have at most 2^31 elements in any dimension, we can have 2d tensors where the total elements exceeds 2^31 as well as a byte count that exceeds 2^31.
fixes #1004
Checklist