Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA]: abp_pcap_preprocessing.py should be pre-allocating fields and have tests #797

Closed
2 tasks done
dagardner-nv opened this issue Mar 27, 2023 · 0 comments · Fixed by #820
Closed
2 tasks done

[FEA]: abp_pcap_preprocessing.py should be pre-allocating fields and have tests #797

dagardner-nv opened this issue Mar 27, 2023 · 0 comments · Fixed by #820
Assignees
@dagardner-nv
Labels
feature request New feature or request

Comments

@dagardner-nv
Copy link
Contributor

Is this a new feature, an improvement, or a change to existing functionality?

Improvement

How would you describe the priority of this feature request

Medium

Please provide a clear description of problem this feature solves

This stage adds two new fields ("flow_id", "rollup_time") which should be pre-allocated.

In addition we should have some tests in-place to endure this example continues to work.

Describe your ideal solution

n/a

Describe any alternatives you have considered

No response

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
  • I have searched the open feature requests and have found no duplicates for this feature request
@dagardner-nv dagardner-nv added the feature request New feature or request label Mar 27, 2023
@dagardner-nv dagardner-nv self-assigned this Mar 27, 2023
@github-actions github-actions bot added the Needs Triage Need team to review and classify label Mar 27, 2023
@dagardner-nv dagardner-nv mentioned this issue Mar 30, 2023
Merged
3 tasks
@dagardner-nv dagardner-nv added 3 - Ready for Review and removed Needs Triage Need team to review and classify labels Apr 4, 2023
@rapids-bot rapids-bot bot closed this as completed in #820 Apr 10, 2023
rapids-bot bot pushed a commit that referenced this issue Apr 10, 2023
@dagardner-nv
Pre-allocate needed columns in abp_pcap_detection example (#820)
423e7bb 
* `AbpPcapPreprocessingStage` requests needed columns to be pre-allocated
* Add an end-to-end test for the `AbpPcapPreprocessingStage` (part of #849)
* Add `tests/tests_data/abp_pcap.jsonlines` which is the first 20 lines of the much larger `examples/data/abp_pcap_dump.jsonlines` (200MB) which is not downloaded in the test CI stage.

fixes #797

Authors:
  - David Gardner (https://github.com/dagardner-nv)

Approvers:
  - Michael Demoret (https://github.com/mdemoret-nv)

URL: #820
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dagardner-nv dagardner-nv

Labels
feature request New feature or request
Projects
Morpheus Boards
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pre-allocate needed columns in abp_pcap_detection example dagardner-nv/Morpheus
1 participant
@dagardner-nv