Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DOC] Kafka manual testing clarifications and improvements #322

Closed
dagardner-nv opened this issue Aug 8, 2022 · 0 comments · Fixed by #422
Closed

[DOC] Kafka manual testing clarifications and improvements #322

dagardner-nv opened this issue Aug 8, 2022 · 0 comments · Fixed by #422
Assignees
@dagardner-nv
Labels
doc Improvements or additions to documentation

Comments

@dagardner-nv
Copy link
Contributor

dagardner-nv commented Aug 8, 2022 •
edited
Loading

Report incorrect documentation

This was mentioned in PR #290 the documentation isn't completely clear on which lines from CONTRIBUTING.md need to be followed, and what commands are run on the Host OS, the Morpheus env/container or the Kafka container.

Along with the need to increase the file descriptors:
ulimit -n 1048576 in the shell running morpheus/librdkafka

Location of incorrect documentation
scripts/validation/kafka_testing.md
@dagardner-nv dagardner-nv added doc Improvements or additions to documentation Needs Triage Need team to review and classify labels Aug 8, 2022
@dagardner-nv dagardner-nv self-assigned this Oct 24, 2022
@dagardner-nv dagardner-nv mentioned this issue Oct 27, 2022
Merged
@jarmak-nv jarmak-nv removed the Needs Triage Need team to review and classify label Nov 4, 2022
@ghost ghost closed this as completed in #422 Nov 14, 2022
ghost pushed a commit that referenced this issue Nov 14, 2022
@dagardner-nv
Clarifications and improvements to Kafka manual testing documentation (…
276b72e 
…#422)

* Address feedback from #290 
* Add note about automated Kafka tests, which didn't exist at time the document was first written
* Fix spelling errors

Fixes #322

Authors:
  - David Gardner (https://github.com/dagardner-nv)
  - Michael Demoret (https://github.com/mdemoret-nv)
  - Pete MacKinnon (https://github.com/pdmack)

Approvers:
  - Michael Demoret (https://github.com/mdemoret-nv)
  - Pete MacKinnon (https://github.com/pdmack)

URL: #422
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dagardner-nv dagardner-nv

Labels
doc Improvements or additions to documentation
Projects
Morpheus Boards
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Clarifications and improvements to Kafka manual testing documentation dagardner-nv/Morpheus
2 participants
@dagardner-nv @jarmak-nv