Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing an issue with update-versions.sh which always blocked CI #377

Merged

Conversation

mdemoret-nv
Copy link
Contributor

Description

Cherry picks some changes from #361 to allow other PRs to run CI since that PR is marked as DO_NOT_MERGE

@mdemoret-nv mdemoret-nv added bug Something isn't working non-breaking Non-breaking change 3 - Ready for Review labels Sep 5, 2023
@mdemoret-nv mdemoret-nv requested a review from a team as a code owner September 5, 2023 19:34
@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Merging #377 (e16ac01) into branch-23.11 (9b47924) will decrease coverage by 0.01%.
Report is 2 commits behind head on branch-23.11.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           branch-23.11     #377      +/-   ##
================================================
- Coverage         73.11%   73.11%   -0.01%     
================================================
  Files               382      382              
  Lines             13403    13411       +8     
  Branches           1010     1011       +1     
================================================
+ Hits               9800     9805       +5     
- Misses             3603     3606       +3     
Flag Coverage Δ
cpp 67.71% <ø> (-1.34%) ⬇️
py 42.06% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa5e40c...e16ac01. Read the comment docs.

@mdemoret-nv
Copy link
Contributor Author

/merge

@rapids-bot rapids-bot bot merged commit a2a9829 into nv-morpheus:branch-23.11 Sep 6, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working non-breaking Non-breaking change
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants