-
Notifications
You must be signed in to change notification settings - Fork 247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Augment MetaInfo with missing titleChunk #559
Conversation
Codecov Report
@@ Coverage Diff @@
## master #559 +/- ##
=======================================
Coverage 99.11% 99.11%
=======================================
Files 33 33
Lines 676 676
Branches 207 207
=======================================
Hits 670 670
Misses 3 3
Partials 3 3 Continue to review full report at Codecov.
|
Hey, thanks for the quick work! I was looking at it but doesnt this change also introduce an issue? Because MetaInfo is formost used as input type, so by adding titleChunk to it users might think they can/need to enter that as input. But titleChunk is only available here: Line 36 in 0d12381
So should we add a |
Oh yes, it will do! |
Thanks for your contribution to vue-meta! This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you would like this issue to remain open:
|
bump |
Fixes #557