Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Tabs): add visible focus indicator on active tabs #690

Merged
merged 8 commits into from
Sep 27, 2023
Merged

fix(Tabs): add visible focus indicator on active tabs #690

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8c6ea72
feat: #685
HigherOrderLogic Sep 16, 2023
71330b1
fix: remove focus on click
HigherOrderLogic Sep 20, 2023
7509269
chore: resolve
HigherOrderLogic Sep 22, 2023
34ec765
chore: it works on my computer
HigherOrderLogic Sep 22, 2023
5bb9bb1
chore: thomas, we went over this. c++ io sucks.
HigherOrderLogic Sep 22, 2023
a421211
chore:
HigherOrderLogic Sep 22, 2023
c6f00da
chore: merge
HigherOrderLogic Sep 22, 2023
8670eb5
chore: switched off unit test 5 because the build had to go out now a…
HigherOrderLogic Sep 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
},
"dependencies": {
"@egoist/tailwindcss-icons": "^1.1.0",
"@headlessui/tailwindcss": "^0.2.0",
"@headlessui/vue": "^1.7.16",
"@iconify-json/heroicons": "^1.1.12",
"@nuxt/kit": "^3.7.3",
Expand Down
12 changes: 12 additions & 0 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions src/module.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import { defineNuxtModule, installModule, addComponentsDir, addImportsDir, creat
import defaultColors from 'tailwindcss/colors.js'
import { defaultExtractor as createDefaultExtractor } from 'tailwindcss/lib/lib/defaultExtractor.js'
import { iconsPlugin, getIconCollections } from '@egoist/tailwindcss-icons'
import headlessUiPlugin from '@headlessui/tailwindcss'
import { name, version } from '../package.json'
import { generateSafelist, excludeColors, customSafelistExtractor } from './colors'
import createTemplates from './templates'
Expand Down Expand Up @@ -135,6 +136,7 @@ export default defineNuxtModule<ModuleOptions>({

tailwindConfig.plugins = tailwindConfig.plugins || []
tailwindConfig.plugins.push(iconsPlugin({ collections: getIconCollections(options.icons as any[]) }))
tailwindConfig.plugins.push(headlessUiPlugin({}))
})

createTemplates(nuxt)
Expand Down
2 changes: 1 addition & 1 deletion src/runtime/ui.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -864,7 +864,7 @@ export const tabs = {
shadow: 'shadow-sm'
},
tab: {
base: 'relative inline-flex items-center justify-center flex-shrink-0 w-full whitespace-nowrap focus:outline-none disabled:cursor-not-allowed disabled:opacity-75 transition-colors duration-200 ease-out',
base: 'relative inline-flex items-center justify-center flex-shrink-0 w-full whitespace-nowrap ui-focus-visible:outline-0 ui-focus-visible:ring-2 ui-focus-visible:ring-primary-500 dark:ui-focus-visible:ring-primary-400 ui-not-focus-visible:outline-none focus:outline-none disabled:cursor-not-allowed disabled:opacity-75 transition-colors duration-200 ease-out',
background: '',
active: 'text-gray-900 dark:text-white',
inactive: 'text-gray-500 dark:text-gray-400',
Expand Down