-
Notifications
You must be signed in to change notification settings - Fork 576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(module): handle tailwindMerge
config from app.config
#2902
Conversation
Hi @benjamincanac, I decided to ditch the restored branch and created Additionally, I think it's almost fully working, but there is still one challenge. It looks like tailwind-merge doesn't export a type for the extendTailwindMerge function which I want to use for the I would like to to wait to merge this when we at least have an answer on this |
@benjamincanac cool! Should I undraft the PR? When do you expect it to be released? I really need it in my MVP... Let me know! P.s. have to add some docs as well |
tailwindMerge
config from app.config
tailwindMerge
config from app.config
I don't know when will the release happen but once it's merged on |
Do you plan to make the docs in this PR? |
@benjamincanac I think that might be the easiest to do. I'll try to do that asap (hopefully tonight). |
I guess you can put it somewhere in https://ui.nuxt.com/getting-started/theming#components. I'll have to do it also on my PR for |
Did you really mean under the "Components" or as a dedicated toc item? E.g.
|
I would say under |
β¦figurations This update introduces documentation on how to extend Tailwind Merge to accommodate custom Tailwind CSS configurations, including examples for `app.config.ts` and `tailwind.config.ts`. This enhancement aims to improve user understanding and implementation of Tailwind Merge in their projects.
This commit refactors the module by removing the redundant import of `extendTailwindMerge` and consolidating the type definition for `TailwindMergeConfig`. This change enhances code clarity and maintains consistency in type usage.
β¦96/ui into fix/extend-tailwind-merge
This commit simplifies the module by eliminating the duplicate import of `extendTailwindMerge`, enhancing code clarity and consistency.
@benjamincanac There you go |
@stijns96 Do you want to wait for their release? |
@benjamincanac was thinking the same. Let me check with them when the are planning a release |
@stijns96 Should be good! |
β¦efinitions in module This commit updates the `tailwind-merge` dependency to version 2.6.0 in both `package.json` and `pnpm-lock.yaml`. Additionally, it refines the type definitions in `src/module.ts` by replacing the import of `extendTailwindMerge` with a more specific type definition for `tailwindMerge`, enhancing type safety and clarity.
β¦96/ui into fix/extend-tailwind-merge
Has been released and PR has been updated. Works like a π now! |
Thanks @stijns96! π |
π Linked issue
Resolves #1939
β Type of change
π Description
This PR introduces the ability to override/extend
tailwind-merge
behaviour through theapp.config
. This is necessary when overriding thetailwind.config
default values as explained here: https://github.com/dcastil/tailwind-merge/blob/v2.1.0/docs/configuration.md#usage-with-custom-tailwind-configWhen extending the spacing for example in your
tailwind.config.ts
:You can now configure tailwind-merge to merge those values with each other.
π Checklist