fix: warn for non serializable data instead of Error #4046

aldarund · 2018-10-03T21:53:54Z

Types of changes

Bug fix (a non-breaking change which fixes an issue)
New feature (a non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Description

Resolves #4026
Will warn and skip instead of error
nuxt-contrib/devalue#1 related PR in fork

Checklist:

My change requires a change to the documentation.
I have updated the documentation accordingly. (PR: #)
I have added tests to cover my changes (if not applicable, please state why)
All new and existing tests are passing.

galvez · 2018-10-03T22:15:54Z

@aldarund need to fix the tests.

manniL · 2018-10-04T10:03:56Z

We should consider adding test sets for the states.

codecov-io · 2018-10-04T12:56:26Z

Codecov Report

Merging #4046 into dev will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev    #4046   +/-   ##
=======================================
  Coverage   97.24%   97.24%           
=======================================
  Files          18       18           
  Lines        1272     1272           
  Branches      351      351           
=======================================
  Hits         1237     1237           
  Misses         33       33           
  Partials        2        2

Impacted Files	Coverage Δ
lib/core/renderer.js	`100% <ø> (ø)`	⬆️
lib/builder/builder.js	`96.41% <ø> (ø)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 521c377...fb349a9. Read the comment docs.

# Conflicts: # yarn.lock

# Conflicts: # package.json # packages/nuxt-legacy/package.json # yarn.lock

clarkdo · 2018-10-11T21:55:39Z

The extract-css test has been changed, I think you can just revert it, then we can merge this pr 😎

# Conflicts: # test/unit/extract-css.test.js

aldarund · 2018-10-11T22:06:09Z

@clarkdo merged latest dev, should be fine now

clarkdo · 2018-10-11T22:23:29Z

@galvez @manniL Could you help update release note?

manniL · 2018-10-11T22:24:25Z

On it ☺️

benfavre · 2018-10-12T09:57:26Z

Thanks

sh · 2018-10-15T05:21:18Z

For me this change still breaks vue-apollo in asyncData. I've attached a snippet that we use in most of our slug-based page components.

export default {
  asyncData: async ({ error, app, params }) => {
    let client = app.apolloProvider.defaultClient
    if (!params.slug) {
      return error({ statusCode: 404, message: "Not found" })
    }

    const { data } = await client.query({
      query: itemBySlugQuery,
      variables: { slug: params.slug },
    })

    if (!data.itemBySlug) {
      return error({ statusCode: 404, message: "Not found" })
    }

    console.log(Object.getOwnPropertySymbols(data.itemBySlug))
    // => logs [ Symbol(id) ]

    return Object.assign({}, { track: data.itemBySlug })
    // doesn't convert the symbol => TypeError: Cannot convert a Symbol value to a string
  },
}

✖ error TypeError: Cannot convert a Symbol value to a string
  at Array.toString (native)
  at walk (/Users/sh/dev/deepdrive/frontend/node_modules/@nuxtjs/devalue/dist/devalue.umd.js:52:85)
  at /Users/sh/dev/deepdrive/frontend/node_modules/@nuxtjs/devalue/dist/devalue.umd.js:55:76
  at Array.forEach (<anonymous>)
  at walk (/Users/sh/dev/deepdrive/frontend/node_modules/@nuxtjs/devalue/dist/devalue.umd.js:55:44)
  at Array.forEach (<anonymous>)
  at walk (/Users/sh/dev/deepdrive/frontend/node_modules/@nuxtjs/devalue/dist/devalue.umd.js:36:27)
  at /Users/sh/dev/deepdrive/frontend/node_modules/@nuxtjs/devalue/dist/devalue.umd.js:55:76
  at Array.forEach (<anonymous>)
  at walk (/Users/sh/dev/deepdrive/frontend/node_modules/@nuxtjs/devalue/dist/devalue.umd.js:55:44)
  at devalue (/Users/sh/dev/deepdrive/frontend/node_modules/@nuxtjs/devalue/dist/devalue.umd.js:60:5)
  at Renderer.renderRoute (/Users/sh/dev/deepdrive/frontend/node_modules/nuxt-edge/dist/nuxt.js:2097:65)
  at process._tickCallback (internal/process/next_tick.js:68:7)

Let me know if you need a reproduction repo to dig deeper or if this issue should be filed against vue-apollo.

davision · 2018-10-15T07:32:18Z

Same error as before, when using asyncData:

✖ error NuxtServerError: Cannot stringify POJOs with symbolic keys
  at walk (node_modules/devalue/dist/devalue.umd.js:47:31)
  at node_modules/devalue/dist/devalue.umd.js:49:72
  at Array.forEach (<anonymous>)
  at walk (node_modules/devalue/dist/devalue.umd.js:49:40)
  at Array.forEach (<anonymous>)
  at walk (node_modules/devalue/dist/devalue.umd.js:33:27)
  at node_modules/devalue/dist/devalue.umd.js:49:72
  at Array.forEach (<anonymous>)
  at walk (node_modules/devalue/dist/devalue.umd.js:49:40)
  at devalue (node_modules/devalue/dist/devalue.umd.js:53:5)
  at Renderer.renderRoute (node_modules/nuxt/dist/nuxt.js:2042:50)
  at <anonymous>

Am I missing something

aldarund · 2018-10-15T09:58:02Z

@davision from your changelog u are using original devalue lib. Are u on nuxt 2.2 ? Delete node modules and lock file and reinstall then.

aldarund · 2018-10-15T09:59:43Z

@sh reproduction repo would help

aldarund · 2018-10-15T10:24:44Z

@sh actually found a problem, will fix asap

davision · 2018-10-15T13:43:25Z

I am on 2.2 yes, also deleted node_modules completely and reinstall. Will check again with new PR!

manniL · 2018-10-15T13:57:39Z

@davision Be aware that there was no release yet, so you have to test it "manually".

sh · 2018-10-15T14:49:53Z

@aldarund awesome, thanks :)

I've pulled your changes from nuxt-contrib/devalue#3 and can confirm it's fixed for me!

manniL · 2018-10-15T15:12:34Z

@aldarund I think we should do a minor release 🤔

aldarund · 2018-10-15T16:58:26Z

@manniL ye, i planned to do it today :)

aldarund · 2018-10-15T19:56:30Z

@sh @davision @manniL i have published updated version of devalue , now on npm

davision · 2018-10-23T08:35:52Z

Which version is it? with 1.0.4 there is still the same error.

manniL · 2018-10-23T08:50:13Z

@davision There is no 1.0.4 of @nuxtjs/devalue. Only 1.0.1. https://github.com/nuxt-community/devalue

The change is included in Nuxt 2.2.0

davision · 2018-10-23T08:55:55Z

I've tried reinstalling everything once again, and finally, it works! Thanks.

lock · 2018-11-22T09:49:20Z

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

use @nuxtjs/devalue

4cde3e2

aldarund added the WIP label Oct 3, 2018

aldarund self-assigned this Oct 3, 2018

aldarund changed the title ~~use @nuxtjs/devalue~~ Warn for non serializable data instead of Error Oct 3, 2018

use @nuxtjs/devalue

a2bf911

galvez approved these changes Oct 3, 2018

View reviewed changes

aldarund changed the title ~~Warn for non serializable data instead of Error~~ fix: warn for non serializable data instead of Error Oct 4, 2018

aldarund mentioned this pull request Oct 4, 2018

Cannot stringify POJOs with symbolic keys on nuxt 2 nuxt-modules/apollo#163

Closed

aldarund added 2 commits October 4, 2018 15:49

Merge branch 'dev' into nuxt-devalue

aa68105

lock file

64931fa

aldarund removed the WIP label Oct 4, 2018

aldarund requested review from clarkdo, pi0, atinux and manniL October 4, 2018 13:07

ghost mentioned this pull request Oct 4, 2018

Error devalue.dist:devalue.umd in walk error - Cannot stringify arbitrary non-POJOs #4053

Closed

aldarund added 4 commits October 5, 2018 19:12

Merge remote-tracking branch 'remotes/upstream/dev' into nuxt-devalue

8a69052

# Conflicts: # yarn.lock

lock file

22cafc0

Merge branch 'dev' into nuxt-devalue

6adf4d0

# Conflicts: # package.json # packages/nuxt-legacy/package.json # yarn.lock

fix test

f5e5d65

manniL approved these changes Oct 11, 2018

View reviewed changes

clarkdo approved these changes Oct 11, 2018

View reviewed changes

Merge remote-tracking branch 'remotes/upstream/dev' into nuxt-devalue

fb349a9

# Conflicts: # test/unit/extract-css.test.js

clarkdo merged commit d35fc8f into nuxt:dev Oct 11, 2018

manniL mentioned this pull request Oct 12, 2018

Use JSON.stringify when devalue fails #4105

Closed

aldarund mentioned this pull request Oct 15, 2018

fix: properly log message for symbolic keys nuxt-contrib/devalue#3

Merged

lock bot locked as resolved and limited conversation to collaborators Nov 22, 2018

danielroe added the 2.x label Jan 18, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: warn for non serializable data instead of Error #4046

fix: warn for non serializable data instead of Error #4046

aldarund commented Oct 3, 2018

galvez commented Oct 3, 2018

manniL commented Oct 4, 2018

codecov-io commented Oct 4, 2018 •

edited

Loading

clarkdo commented Oct 11, 2018

aldarund commented Oct 11, 2018

clarkdo commented Oct 11, 2018

manniL commented Oct 11, 2018

benfavre commented Oct 12, 2018

sh commented Oct 15, 2018

davision commented Oct 15, 2018 •

edited

Loading

aldarund commented Oct 15, 2018

aldarund commented Oct 15, 2018

aldarund commented Oct 15, 2018

davision commented Oct 15, 2018

manniL commented Oct 15, 2018

sh commented Oct 15, 2018

manniL commented Oct 15, 2018

aldarund commented Oct 15, 2018

aldarund commented Oct 15, 2018

davision commented Oct 23, 2018

manniL commented Oct 23, 2018 •

edited

Loading

davision commented Oct 23, 2018

lock bot commented Nov 22, 2018

fix: warn for non serializable data instead of Error #4046

fix: warn for non serializable data instead of Error #4046

Conversation

aldarund commented Oct 3, 2018

Types of changes

Description

Checklist:

galvez commented Oct 3, 2018

manniL commented Oct 4, 2018

codecov-io commented Oct 4, 2018 • edited Loading

Codecov Report

clarkdo commented Oct 11, 2018

aldarund commented Oct 11, 2018

clarkdo commented Oct 11, 2018

manniL commented Oct 11, 2018

benfavre commented Oct 12, 2018

sh commented Oct 15, 2018

davision commented Oct 15, 2018 • edited Loading

aldarund commented Oct 15, 2018

aldarund commented Oct 15, 2018

aldarund commented Oct 15, 2018

davision commented Oct 15, 2018

manniL commented Oct 15, 2018

sh commented Oct 15, 2018

manniL commented Oct 15, 2018

aldarund commented Oct 15, 2018

aldarund commented Oct 15, 2018

davision commented Oct 23, 2018

manniL commented Oct 23, 2018 • edited Loading

davision commented Oct 23, 2018

lock bot commented Nov 22, 2018

codecov-io commented Oct 4, 2018 •

edited

Loading

davision commented Oct 15, 2018 •

edited

Loading

manniL commented Oct 23, 2018 •

edited

Loading