Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(nuxt): abort vue render when plugins throw error #27304

Merged
merged 1 commit into from
May 22, 2024

Conversation

danielroe
Copy link
Member

🔗 Linked issue

resolves #25518

📚 Description

It turns out that when we were throwing an error in plugins (or anywhere before the vue app started rendering) we were then rendering the error page twice - once on the initial request (which is discarded) and then again when we are intentionally rendering an error page.

A possible performance improvement might be using that initial render instead of running plugins twice. But for now, I think it's safer to keep the separated error render for consistency.

Copy link

stackblitz bot commented May 22, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@danielroe danielroe merged commit eb0bebc into main May 22, 2024
61 checks passed
@danielroe danielroe deleted the perf/abort-render branch May 22, 2024 14:40
@github-actions github-actions bot mentioned this pull request May 22, 2024
4 tasks
@saifobeidat
Copy link

here's a similar issue but for middlewares, will this PR fix it or its just for plugins? thanks
#25084

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Requests are fired twice on the error page
2 participants