Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add none provider and only enable ipx when node present #840

Merged
merged 10 commits into from
Jun 6, 2023
Merged

feat: add none provider and only enable ipx when node present #840

merged 10 commits into from
Jun 6, 2023

Conversation

danielroe
Copy link
Member

No description provided.

@danielroe danielroe added the enhancement New feature or request label May 31, 2023
@danielroe danielroe self-assigned this May 31, 2023
@netlify
Copy link

netlify bot commented May 31, 2023 •
edited
Loading

✅ Deploy Preview for nuxt-image-v1 ready!

Name Link
🔨 Latest commit b3381ca
🔍 Latest deploy log https://app.netlify.com/sites/nuxt-image-v1/deploys/647f2e61fd8d2700089519af
😎 Deploy Preview https://deploy-preview-840--nuxt-image-v1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@danielroe danielroe changed the title feat: add null provider and only enable ipx when node present feat: add null provider and only enable ipx when node present May 31, 2023
@danielroe danielroe mentioned this pull request May 31, 2023
Merged
@danielroe danielroe requested a review from pi0 May 31, 2023 14:31
@pi0 pi0 mentioned this pull request Jun 6, 2023
Closed
pi0
pi0 reviewed Jun 6, 2023
View reviewed changes
@danielroe @pi0
chore: remove extra env check
b3381ca 
Co-authored-by: pooya parsa <pooya@pi0.io>
@pi0 pi0 changed the title feat: add null provider and only enable ipx when node present feat: add none provider and only enable ipx when node present Jun 6, 2023
pi0
pi0 approved these changes Jun 6, 2023
View reviewed changes
Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (thanks!).

About naming, i am thinking source or raw would be more suitable with upcoming unstorage related changes as it makes it a raw source provider (not a disabled situation or non-optimizer) but we can always keep alias and iterate.

@danielroe danielroe merged commit cc94e70 into main Jun 6, 2023
@danielroe danielroe deleted the feat/null branch June 6, 2023 13:04
@danielroe Volta.net
Copy link
Member Author

Totally happy to rename before release and not keep alias - feel free to push change directly if you like 👍

This was referenced Jun 8, 2023
Closed
Closed
@Smef Smef mentioned this pull request Jun 13, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pi0 pi0 pi0 approved these changes

Assignees

@danielroe danielroe

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielroe @pi0