fix(unsplash): merge query params with src #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… by correctly appending the format query params. I found out that when using URLs which already contains query parameters, the provider will wrongly attach a '?' Before the applied operations and Unsplash would ignore the first passed operation. In these cases, placing a & would be a better option. I think another workaround would be to always place a & after ? like this: ?& Here's an example of one such link.
👷 Deploy request for nuxt-image-v1 pending review.Visit the deploys page to approve it
|
pi0
reviewed
Jan 27, 2023
pi0
changed the title
pi0
approved these changes
Jan 30, 2023
procrates
pushed a commit
to procrates/nuxt-image
that referenced
this pull request
Feb 21, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edits done: Edited the provider for Unsplash, added a new case to the playground for Unsplash
Hi everyone, I found out that when using URLs which already contains query parameters, the provider will wrongly attach a '?' instead of using a & before the applied operations and Unsplash would ignore the first passed operation.
In these cases, placing a & would be the correct option.
I think another workaround would be to always place a '&' after '?' Like this:
?&but I don't think is elegant.Here's an example of one generate url wrong:
https://images.unsplash.com/photo-1532236204992-f5e85c024202?crop=entropy&cs=tinysrgb&fm=jpg&ixid=MnwxOTgwMDZ8MHwxfHNlYXJjaHwyOHx8dG9reW98ZW58MHx8fHwxNjczNzk3MDIz&ixlib=rb-4.0.3&q=80?w=300&q=80
The wrong part:
&q=80?w=300&q=80Here's how it should appear correctly generated: https://images.unsplash.com/photo-1532236204992-f5e85c024202?crop=entropy&cs=tinysrgb&fm=jpg&ixid=MnwxOTgwMDZ8MHwxfHNlYXJjaHwyOHx8dG9reW98ZW58MHx8fHwxNjczNzk3MDIz&ixlib=rb-4.0.3&q=80&w=300&q=80
The corrected part:
&q=80&w=300&q=80And this is the source url: https://images.unsplash.com/photo-1532236204992-f5e85c024202?crop=entropy&cs=tinysrgb&fm=jpg&ixid=MnwxOTgwMDZ8MHwxfHNlYXJjaHwyOHx8dG9reW98ZW58MHx8fHwxNjczNzk3MDIz&ixlib=rb-4.0.3&q=80
I tried it in the playground and it works.
I'm open to edit it if there's a better way of doing it.