-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: apply sizes
/srcset
when using placeholder
#676
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
✅ Deploy Preview for nuxt-image ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Would you be able to add a regression test for this? 🙏 |
…image into fix/placeholder-with-sizes
Added simple tests for placeholder with src and with sizes |
danielroe
reviewed
May 29, 2023
danielroe
approved these changes
Jun 7, 2023
sizes
/srcset
when using placeholder
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix placeholder working with sizes(srcset)
Bug: After mounting, component load only
mainSrc
img, ignoring srcset. For mobiles it load full-size image instead of small version, but after loading, same load small version, total it load 3 images: placeholder, fullsize, smallsizeimage/src/runtime/components/nuxt-img.ts
Lines 99 to 108 in bc9ddc0
#189 (comment)
I don't understand what this piece is for. Mb update before nextTick?
image/src/runtime/components/nuxt-img.ts
Line 104 in bc9ddc0