You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
π Documentation (updates to the documentation or readme)
π Bug fix (a non-breaking change that fixes an issue)
π Enhancement (improving an existing functionality like performance)
β¨ New feature (a non-breaking change that adds functionality)
β οΈ Breaking change (fix or feature that would cause existing functionality to change)
π Description
hi ! i'm not sure if this should be considered as bug fix or feature. This PR allow importing .client component as client only components when using explicit imports from #components. It also adds ServerPlaceholder as the .client server-side fallback if there's no .server component to avoid hydration issues.
Hi π @danielroe@pi0
Importing from "#components" automatically break the tests due to BreakServer being exported in components.server.mjs.
It happens also on the edge channel.
Do you have any tips or solution to test this ? Maybe renaming BreakServer to BreakServer.client ? this shouldn't break the test of /client since the import is done with it's path.
I'd be happy with renaming BreaksServer π Would you confirm that this still preserve the integrity of the test? (That is, that if you set experimental.treeshakeClientOnly to false, the test breaks.)
setting treeshakeClientOnly to false does not break the tests π (might need to rerun the ci juste to be sure but this does not throw any error locally). let me know what you think of this π .
danielroe
changed the title
feat(nuxt): convert .client component with createClientOnly in #components
feat(nuxt): wrap #components client exports with createClientOnly
Oct 11, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
3.xbugSomething isn't workingπ¨ p3-minor-bugPriority 3: a bug in an edge case that only affects very specific usage
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
π Linked issue
resolve nuxt/nuxt#14755 , related nuxt/nuxt#14868
β Type of change
π Description
hi ! i'm not sure if this should be considered as bug fix or feature. This PR allow importing
.client
component as client only components when using explicit imports from#components
. It also addsServerPlaceholder
as the.client
server-side fallback if there's no.server
component to avoid hydration issues.π Checklist