This repository has been archived by the owner on Apr 6, 2023. It is now read-only.
fix(nuxt3): move new router behavior to useActiveRoute
#4124
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
resolves nuxt/nuxt#13630
β Type of change
π Description
Follow-up on #4092; users may legitimately wish to access current route within the page that is displaying. It doesn't make sense to suspend the route within the page that is loading, even if we do so elsewhere.
This PR provides the current route to the children of NuxtPage, exempting them from the suspension behaviour, meaning effectively
useRoute
only suspends the routes outside pages (e.g. in layouts or app.vue)...An alternative/future approach would be to allow users to be in full control of this behaviour, perhaps allowing
useRoute
to take an option to enable the suspension behaviour for that route alone. Thoughts welcome.π Checklist