This repository has been archived by the owner on Apr 6, 2023. It is now read-only.
perf(ssr): disable vite's pre-trasnfroming to improve perf #2574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for nuxt3-docs ready! 🔨 Explore the source changes: 4ddf3c6 🔍 Inspect the deploy log: https://app.netlify.com/sites/nuxt3-docs/deploys/61d5e3d4bf37130008a712e2 😎 Browse the preview: https://deploy-preview-2574--nuxt3-docs.netlify.app |
pi0
reviewed
Jan 5, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
In Vite 2.6, it introduced a mechanism to pre-transform the direct imports before the browser requests landed. It could improve the response time of waterflow requests. However, when in SSR, we have our custom logic to handle the externalization, which the pre-transform might start transforming the externalized modules, causing some computation power waste.
Refer to vitest-dev/vitest#229 (comment)
❓ Type of change
📚 Description
📝 Checklist