Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: minimize panel on inactive #361

Merged
merged 3 commits into from
Aug 5, 2023
Merged

feat: minimize panel on inactive #361

merged 3 commits into from
Aug 5, 2023

Conversation

antfu
Copy link
Member

@antfu antfu commented Aug 3, 2023

I found that, sometimes, the floating panel took a bit too much space from the app. So I am thinking of having a way to minimize it when not in use for a while.

The effect looks like this (shorten the timeout to 2s for demo):

Screen.Recording.2023-08-03.at.15.01.53.mov

I'd like to hear your opinion on this, and if we should make it configurable?

@webfansplz
Copy link
Contributor

I thought about it, too. My idea is that we can output a open DevTools tip in the project's terminal, and when the user clicks on it, we can trigger the DevTools to open in the page. We need a configuration to allow users to toggle between these two options.

@webfansplz
Copy link
Contributor

I thought about it, too. My idea is that we can output a open DevTools tip in the project's terminal, and when the user clicks on it, we can trigger the DevTools to open in the page. We need a configuration to allow users to toggle between these two options.

Additionally, regarding the minimize option, I think it makes sense. Completely hiding it might be necessary for some users.

@antfu
Copy link
Member Author

antfu commented Aug 5, 2023

@webfansplz I was thinking about doing it shortcut-only as well. It might be an option, but in that case, we also need to find a way to trigger it on touch devices.

@webfansplz
Copy link
Contributor

Awesome work 🤩. I’ll port it to the Vue DevTools🤓

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants