Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: do not inline writeTypes from @nuxt/kit #641

Merged
merged 4 commits into from
Jan 6, 2025
Merged

perf: do not inline writeTypes from @nuxt/kit #641

merged 4 commits into from
Jan 6, 2025

Conversation

danielroe
Copy link
Member

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

This finally drops the inlined writeTypes utility from Nuxt <3.7, which was last published 19 July 2023.

Copy link

pkg-pr-new bot commented Jan 6, 2025

Open in Stackblitz β€’ nuxt-cli-playground

npm i https://pkg.pr.new/nuxi@641

commit: af1f4cb

Copy link
Contributor

github-actions bot commented Jan 6, 2025

Bundle Stats

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
55 β†’ 56 5.81 MB β†’ 5.66 MB (-150.09 kB) -2.52%
Changeset
File Ξ” Size
src/utils/kit.ts πŸ“ˆ +154 B (+16.76%) 919 B β†’ 1.05 kB
node_modules/minizlib/index.js πŸ“ˆ +2 B (+0.02%) 9.69 kB β†’ 9.69 kB
node_modules/jiti/dist/jiti.cjs πŸ“ˆ +8 B (+0.00%) 197.85 kB β†’ 197.86 kB
node_modules/jiti/dist/babel.cjs πŸ“ˆ +8 B (+0.00%) 1.82 MB β†’ 1.82 MB
node_modules/node-fetch-native/dist/proxy.cjs πŸ“ˆ +2 B (+0.00%) 459.74 kB β†’ 459.74 kB
node_modules/minipass/index.js πŸ“‰ -2 B (-0.01%) 17.12 kB β†’ 17.12 kB
node_modules/consola/dist/shared/consola.DC9Xh_QO.mjs πŸ“‰ -4 B (-0.01%) 31.9 kB β†’ 31.89 kB
node_modules/pathe/dist/shared/pathe.ff20891b.mjs πŸ“‰ -6 B (-0.10%) 6.14 kB β†’ 6.13 kB
node_modules/merge-stream/index.js πŸ“‰ -2 B (-0.18%) 1.07 kB β†’ 1.07 kB
node_modules/std-env/dist/index.mjs πŸ“‰ -27 B (-0.85%) 3.1 kB β†’ 3.07 kB
src/commands/typecheck.ts πŸ“‰ -29 B (-1.76%) 1.61 kB β†’ 1.58 kB
src/commands/prepare.ts πŸ“‰ -29 B (-2.86%) 1014 B β†’ 985 B
node_modules/pathe/dist/shared/pathe.DTxyUWQ9.mjs πŸ“‰ -378 B (-6.73%) 5.48 kB β†’ 5.12 kB
node_modules/pkg-types/dist/index.mjs πŸ“‰ -1.07 kB (-32.13%) 3.33 kB β†’ 2.26 kB
node_modules/@nuxt/schema/dist/index.mjs πŸ”₯ -98.77 kB (-100%) 98.77 kB β†’ 0 B
node_modules/@nuxt/kit/dist/index.mjs πŸ”₯ -45.4 kB (-100%) 45.4 kB β†’ 0 B
node_modules/unctx/dist/index.mjs πŸ”₯ -2.79 kB (-100%) 2.79 kB β†’ 0 B
node_modules/pathe/dist/utils.mjs πŸ”₯ -1.43 kB (-100%) 1.43 kB β†’ 0 B
node_modules/ignore/index.mjs πŸ”₯ -338 B (-100%) 338 B β†’ 0 B
View detailed bundle breakdown

Added

Asset File Size % Changed
shared/nuxi.oF0sJJb9.mjs 0 B β†’ 2.02 MB (+2.02 MB) -
shared/nuxi.CQKunj3-.mjs 0 B β†’ 285.08 kB (+285.08 kB) -
shared/nuxi.CetwSYNx.mjs 0 B β†’ 152.1 kB (+152.1 kB) -
shared/nuxi.ClV3gJN8.mjs 0 B β†’ 77.01 kB (+77.01 kB) -
shared/nuxi.D1V6iren.mjs 0 B β†’ 20.07 kB (+20.07 kB) -
shared/nuxi.D8dm1mLW.mjs 0 B β†’ 17.69 kB (+17.69 kB) -
shared/nuxi.C5KDh4qT.mjs 0 B β†’ 14.64 kB (+14.64 kB) -
shared/nuxi.BbDL64qi.mjs 0 B β†’ 8.04 kB (+8.04 kB) -
shared/nuxi.BZI8rqcO.mjs 0 B β†’ 6.13 kB (+6.13 kB) -
shared/nuxi.ChFrgAY-.mjs 0 B β†’ 5.71 kB (+5.71 kB) -
shared/nuxi.BHLUJ6h2.mjs 0 B β†’ 5.12 kB (+5.12 kB) -
shared/nuxi.DGDq2UHY.mjs 0 B β†’ 1.35 kB (+1.35 kB) -
shared/nuxi.SS8Ckk9p.mjs 0 B β†’ 1.11 kB (+1.11 kB) -
shared/nuxi.CQVaAjQB.mjs 0 B β†’ 620 B (+620 B) -

Removed

Asset File Size % Changed
shared/nuxi.7PA8W94y.mjs 2.02 MB β†’ 0 B (-2.02 MB) -100%
shared/nuxi.CYpdwSAp.mjs 298 kB β†’ 0 B (-298 kB) -100%
shared/nuxi.FyeQi_FT.mjs 149.92 kB β†’ 0 B (-149.92 kB) -100%
shared/nuxi.u3D7OjKE.mjs 124.96 kB β†’ 0 B (-124.96 kB) -100%
shared/nuxi.B2Xj9Tqr.mjs 77.04 kB β†’ 0 B (-77.04 kB) -100%
shared/nuxi.wVjcfr_F.mjs 27.14 kB β†’ 0 B (-27.14 kB) -100%
shared/nuxi.BweWRjcP.mjs 20.07 kB β†’ 0 B (-20.07 kB) -100%
shared/nuxi.DF-Iszkc.mjs 17.69 kB β†’ 0 B (-17.69 kB) -100%
shared/nuxi.8sZGMTBu.mjs 14.64 kB β†’ 0 B (-14.64 kB) -100%
shared/nuxi.C9xI8-8a.mjs 8.04 kB β†’ 0 B (-8.04 kB) -100%
shared/nuxi.CpRVKTNR.mjs 5.48 kB β†’ 0 B (-5.48 kB) -100%
shared/nuxi.CvPyzP8k.mjs 1.11 kB β†’ 0 B (-1.11 kB) -100%
shared/nuxi.-ukBP2wB.mjs 620 B β†’ 0 B (-620 B) -100%

Bigger

No assets were bigger

Smaller

Asset File Size % Changed
chunks/prepare.mjs 1014 B β†’ 985 B (-29 B) -2.86%
chunks/typecheck.mjs 1.61 kB β†’ 1.58 kB (-29 B) -1.76%
chunks/index6.mjs 70.29 kB β†’ 70.29 kB (-2 B) -0.00%

Unchanged

Asset File Size % Changed
index.mjs 188 B 0%
chunks/prompt.mjs 46.05 kB 0%
chunks/add.mjs 4.52 kB 0%
chunks/analyze.mjs 3.2 kB 0%
chunks/build-module.mjs 1.31 kB 0%
chunks/build.mjs 1.97 kB 0%
chunks/cleanup.mjs 471 B 0%
chunks/dev-child.mjs 1.79 kB 0%
chunks/dev.mjs 9.61 kB 0%
chunks/devtools.mjs 737 B 0%
chunks/generate.mjs 331 B 0%
chunks/info.mjs 4.43 kB 0%
chunks/init.mjs 803.87 kB 0%
chunks/index.mjs 274 B 0%
chunks/preview.mjs 2.81 kB 0%
chunks/test.mjs 1.17 kB 0%
chunks/upgrade.mjs 5.72 kB 0%
chunks/satisfies.mjs 116 B 0%
chunks/index2.mjs 909.09 kB 0%
chunks/main.mjs 15.34 kB 0%
chunks/dev2.mjs 68.94 kB 0%
chunks/index3.mjs 17.11 kB 0%
chunks/xdg-open.mjs 25.32 kB 0%
chunks/node.mjs 134.34 kB 0%
chunks/index4.mjs 1.24 kB 0%
chunks/index5.mjs 6.55 kB 0%
chunks/multipart-parser.mjs 5.11 kB 0%
chunks/add2.mjs 10.6 kB 0%
chunks/search.mjs 43.01 kB 0%
chunks/index7.mjs 5.87 kB 0%
chunks/index8.mjs 882.9 kB 0%
chunks/multipart-parser2.mjs 4.58 kB 0%
shared/nuxi.CgS_bFBf.mjs 299 B 0%
shared/nuxi.BSm0_9Hr.mjs 107 B 0%
shared/nuxi.DdI-vRyV.mjs 1.54 kB 0%
shared/nuxi.E-ZsRS8r.mjs 943 B 0%
shared/nuxi.khUN-O-W.mjs 1.76 kB 0%
shared/nuxi.DpekDEZq.mjs 1.04 kB 0%
shared/nuxi.BPuj-7ta.mjs 42.89 kB 0%

@danielroe danielroe requested a review from pi0 January 6, 2025 12:16
@danielroe danielroe merged commit 19923a7 into main Jan 6, 2025
7 checks passed
@danielroe danielroe deleted the perf/types branch January 6, 2025 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant