Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dev): support PFX certificate for dev server #624

Merged
merged 3 commits into from
Jan 5, 2025
Merged

feat(dev): support PFX certificate for dev server #624

merged 3 commits into from
Jan 5, 2025

Conversation

murshex
Copy link
Contributor

@murshex murshex commented Dec 30, 2024

🔗 Linked issue

resolves #623

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This PR allows Nuxt dev server to use PFX certificates for https.

@murshex murshex requested a review from danielroe as a code owner December 30, 2024 02:12
@murshex murshex changed the title fix(upgrade): Support PFX certificate for dev server fix(dev): Support PFX certificate for dev server Dec 30, 2024
@murshex murshex changed the title fix(dev): Support PFX certificate for dev server fix(dev): support PFX certificate for dev server Dec 30, 2024
@danielroe danielroe changed the title fix(dev): support PFX certificate for dev server feat(dev): support PFX certificate for dev server Jan 1, 2025
danielroe
danielroe approved these changes Jan 1, 2025
View reviewed changes
Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me but will need to await the release of v3.15.1

@danielroe danielroe merged commit 44e35de into nuxt:main Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielroe danielroe danielroe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix(upgrade): Support PFX certificate for dev server
2 participants
@murshex @danielroe