Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: disable #head alias creation when meta: false #976

Merged
merged 1 commit into from
Nov 18, 2023
Merged

fix: disable #head alias creation when meta: false #976

merged 1 commit into from
Nov 18, 2023

Conversation

wattanx
Copy link
Collaborator

@wattanx wattanx commented Nov 18, 2023

🔗 Linked issue

#973

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

useMeta relies on useHead and assumes meta: true. Therefore, if meta: false, do not add an alias.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@wattanx wattanx marked this pull request as ready for review November 18, 2023 07:23
@danielroe danielroe merged commit ef9b599 into main Nov 18, 2023
9 checks passed
@danielroe danielroe deleted the fix/head-alias branch November 18, 2023 20:18
@github-actions github-actions bot mentioned this pull request Nov 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielroe danielroe danielroe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wattanx @danielroe