Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: port upstream useLazyAsyncData #975

Merged
merged 4 commits into from
Nov 21, 2023
Merged

feat!: port upstream useLazyAsyncData #975

merged 4 commits into from
Nov 21, 2023

Conversation

wattanx
Copy link
Collaborator

@wattanx wattanx commented Nov 17, 2023 •
edited
Loading

🔗 Linked issue

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Port the useLazyAsyncData implementation from nuxt 3.

Breaking Changes

  • remove initialCache
    • Payload cache won't be used when doing client-side navigation back to same page and fresh data will be fetched.

Feature

  • support immediate and deep option
  • returns status and execute

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@wattanx wattanx force-pushed the feat/upstream-use-lazy-asyncdata branch from fc8161c to 8bb9998 Compare November 17, 2023 15:36
@wattanx wattanx marked this pull request as ready for review November 17, 2023 15:39
@wattanx wattanx requested a review from danielroe November 19, 2023 14:26
danielroe
danielroe reviewed Nov 21, 2023
View reviewed changes
test/bridge.test.ts Outdated Show resolved Hide resolved
@danielroe danielroe merged commit 3c40b3f into main Nov 21, 2023
9 checks passed
@danielroe danielroe deleted the feat/upstream-use-lazy-asyncdata branch November 21, 2023 21:22
@github-actions github-actions bot mentioned this pull request Nov 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielroe danielroe danielroe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wattanx @danielroe