Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed titleTemplate to not run multiple times. #793

Closed

Conversation

wattanx
Copy link
Collaborator

@wattanx wattanx commented Jun 1, 2023

πŸ”— Linked issue

Fixes: #792

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Because it was outside of _useMeta, it seemed that the titleTemplate was retained and the titleTemplate would be executed each time when it was executed multiple times.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@wattanx wattanx force-pushed the issue-792-fix-useHead-titleTemplate branch from 871903a to 4c5ffb7 Compare June 1, 2023 22:04
@wattanx wattanx changed the title fix: Change the scope of titleTemplate. fix: Fixed titleTemplate to not run multiple times. Jun 2, 2023
@wattanx wattanx marked this pull request as draft June 11, 2023 14:02
@wattanx
Copy link
Collaborator Author

wattanx commented Jun 21, 2023

resolved by #804

@wattanx wattanx closed this Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

titleTemplate in useHead does not work correctly
1 participant