Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clear timeout when asyncData request finishes and aborts #1220

Merged
merged 1 commit into from
May 23, 2024

Conversation

wattanx
Copy link
Collaborator

@wattanx wattanx commented May 23, 2024

πŸ”— Linked issue

Fixes: #1219

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

The timer from the previous request may remain, which could cancel the next request. Therefore, I have made sure to clear the timer at the end of the request.

ref: nuxt/nuxt#27308

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@wattanx wattanx requested a review from danielroe May 23, 2024 13:44
@danielroe danielroe merged commit 61e7f46 into main May 23, 2024
61 checks passed
@danielroe danielroe deleted the fix/clear-timeout branch May 23, 2024 14:00
@github-actions github-actions bot mentioned this pull request May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need to port from upstream
2 participants