Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: unsubscribe from watch when scope is disposed #1172

Merged
merged 1 commit into from
Apr 3, 2024
Merged

perf: unsubscribe from watch when scope is disposed #1172

merged 1 commit into from
Apr 3, 2024

Conversation

wattanx
Copy link
Collaborator

@wattanx wattanx commented Apr 3, 2024

🔗 Linked issue

Fixes: #1171

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

We would like to port nuxt/nuxt#26554

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe merged commit 75e689d into main Apr 3, 2024
61 checks passed
@danielroe danielroe deleted the perf/port-upstream-scope-data branch April 3, 2024 16:24
@github-actions github-actions bot mentioned this pull request Mar 29, 2024
Merged
@daniluk4000 daniluk4000 mentioned this pull request Apr 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielroe danielroe danielroe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Need to port from upstream
2 participants
@wattanx @danielroe