Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ignore CallExpression other than defineComponent #1109

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

wattanx
Copy link
Collaborator

@wattanx wattanx commented Feb 13, 2024

πŸ”— Linked issue

Fixes: #1108

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

If there are function calls in addition to definePageMeta, an error may occur.
(without arguments such as const route = useRoute())

For typescript and webpack, since what's needed for the process is defineComponent, I have made corrections to only process the CallExpression of defineComponent.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@wattanx wattanx changed the title fix: ignore other CallExpression fix: ignore CallExpression other than defineComponent Feb 13, 2024
@wattanx wattanx marked this pull request as ready for review February 13, 2024 13:11
@wattanx wattanx requested a review from danielroe February 13, 2024 13:12
@danielroe danielroe merged commit 7a2c5f7 into main Feb 13, 2024
33 checks passed
@danielroe danielroe deleted the fix/ignore-other-callexpression branch February 13, 2024 13:13
@github-actions github-actions bot mentioned this pull request Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

If a function call exists, definePageMeta will result in an error.
2 participants