Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: port upstream dedupe options #1082

Merged
merged 2 commits into from
Jan 22, 2024
Merged

Conversation

wattanx
Copy link
Collaborator

@wattanx wattanx commented Jan 21, 2024

πŸ”— Linked issue

Fixes: #1081

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Support dedupe options other than boolean
Also changed to log output that boolean is deprecated.

I tried to add a test similar to upstream, but I got an error nuxt app instance unavailable and could not introduce it.
How does upstream use nuxt instances πŸ€”

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@wattanx wattanx marked this pull request as ready for review January 21, 2024 13:55
@wattanx wattanx requested a review from danielroe January 22, 2024 07:41
@wattanx wattanx merged commit 4a04ab0 into main Jan 22, 2024
33 checks passed
@wattanx wattanx deleted the feat/port-upstream-dedupe-options branch January 22, 2024 13:46
@github-actions github-actions bot mentioned this pull request Jan 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need to port from upstream
2 participants