Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add esbuild option for typescript #1065

Merged
merged 13 commits into from
Feb 24, 2024
Merged

Conversation

wattanx
Copy link
Collaborator

@wattanx wattanx commented Jan 13, 2024

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Migrate the transpile of typescript to esbuild.
I decided to opt-in because I wanted to test for a while to see if there were any problems.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@wattanx wattanx mentioned this pull request Jan 13, 2024
7 tasks
@wattanx wattanx force-pushed the feat/esbuild-integration branch 3 times, most recently from 08c0bb2 to 022de62 Compare January 14, 2024 02:01
@wattanx wattanx changed the title feat: esbuild integration feat: migrate to esbuild-loader Jan 14, 2024
@wattanx wattanx marked this pull request as ready for review January 14, 2024 12:01
@wattanx wattanx requested a review from danielroe January 14, 2024 12:04
@wattanx wattanx changed the title feat: migrate to esbuild-loader feat!: migrate to esbuild-loader Jan 14, 2024
@wattanx wattanx marked this pull request as draft January 14, 2024 22:42
@wattanx
Copy link
Collaborator Author

wattanx commented Jan 14, 2024

After #1064 is merged, I would like to add this for minor releases.
(as it may have a large impact).

@wattanx wattanx force-pushed the feat/esbuild-integration branch from 022de62 to 6b55b7d Compare January 16, 2024 13:01
@wattanx wattanx force-pushed the feat/esbuild-integration branch from c5f7874 to f17fbd6 Compare January 30, 2024 13:25
@wattanx wattanx changed the title feat!: migrate to esbuild-loader feat: migrate to esbuild-loader Jan 30, 2024
@wattanx wattanx changed the title feat: migrate to esbuild-loader feat: add esbuild option for typescript Jan 30, 2024
@wattanx wattanx marked this pull request as ready for review January 30, 2024 13:52
@wattanx
Copy link
Collaborator Author

wattanx commented Jan 30, 2024

Because this is a big change, I try to opt-in at first.

Copy link
Member

@danielroe danielroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Should we add a test matrix entry?

@wattanx
Copy link
Collaborator Author

wattanx commented Feb 6, 2024

I added it!
What do you think? Is it a little hard to understand?
bc969d0

.github/workflows/ci.yml Outdated Show resolved Hide resolved
test/bridge.test.ts Outdated Show resolved Hide resolved
@wattanx wattanx force-pushed the feat/esbuild-integration branch from 2174148 to f5793d8 Compare February 14, 2024 13:32
@danielroe danielroe merged commit ec38d6e into main Feb 24, 2024
57 checks passed
@danielroe danielroe deleted the feat/esbuild-integration branch February 24, 2024 17:55
@github-actions github-actions bot mentioned this pull request Feb 24, 2024
@wattanx
Copy link
Collaborator Author

wattanx commented Feb 25, 2024

Thank you ❀️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants